search

openfun / jitsi-magnify

An authentication and room management system for Jitsi built with Django/React
MIT License
23 stars 6 forks source link

🌐(translations) fix translations issues in fr-FR.json #229

Closed RaoufCherif closed 1 year ago

RaoufCherif commented 1 year ago

Purpose

Fix translations issue

Body

Improve a few french translations issues in the fr-Fr.json

Moustique82 commented 1 year ago

line 61: Salle publique --> espace virtuelle publique line 101 : Reglages --> Paramètres line 107 : Réglage salle --> Paramètres espace virtuelle

jbpenrath commented 1 year ago

@RaoufCherif, I updated translation message on crowdin (the platform on which we are translating messages) then download and compile translations through the command make i18n-download-and-compile.

I push a fixup commit to your PR. Review then squash it.

RaoufCherif commented 1 year ago

Hi, I've squashed and fixed the lint tests. However there are still some back tests failing and I might have missed something but it doesn't seems related to my PR. Do you know if it'll be fixed or do you want me to fix them in this PR ?

jbpenrath commented 1 year ago

Hi, I've squashed and fixed the lint tests. However there are still some back tests failing and I might have missed something but it doesn't seems related to my PR. Do you know if it'll be fixed or do you want me to fix them in this PR ?

Yup, we are aware about this issue. It has been fixed within the PR #223

jbpenrath commented 1 year ago

@RaoufCherif, the issue has been fixed. Update our branch then you will be able to merge your PR 🥳