search

openfun / jitsi-magnify

An authentication and room management system for Jitsi built with Django/React
MIT License
23 stars 6 forks source link

Create a row to display a single meeting #35

Closed Leonils closed 2 years ago

Leonils commented 2 years ago

Purpose

Create a row to display a meeting

Proposal

Create a component to display all needed information, and some logic to handle "joining a meeting", and to extract to the pattern of meetings the actual next meeting

Screenshot from 2022-06-27 16-12-42 Screenshot from 2022-06-27 16-12-52 Screenshot from 2022-06-27 16-12-59

kernicPanel commented 2 years ago

Not really a review, but more a general comment: I think you should split this commit into several ones.

Leonils commented 2 years ago

About Luxon, I'm always asking myself about this kind of library. They are really helpful but usually only on a very specific part of an application, and we use a very small part of the library itself... It may save one hour, but not convinced yet...

kernicPanel commented 2 years ago

I'm old and lazy, but I get your point :) Personally, I already have enough edge cases to manage. So I don't need to support timezone date time ones if they are already solved.