Closed Leonils closed 2 years ago
Could you please rebase ? The conflicts seems easy to solve.
About the Disambiguation, it should not be visible too often, but only when we have a doubt on what the user want to do, for instance if there are 2 meetings at the same time, of very close, so the name. But if you prefer, I can rename it.
Something else @kernicPanel, Could you please check the logs of the test step? The react sdk for jitsi is not transpiled, and that makes the tests to crash on the demo. Have you an idea on how to solve that ? Thank you
About the Disambiguation, it should not be visible too often, but only when we have a doubt on what the user want to do, for instance if there are 2 meetings at the same time, of very close, so the name. But if you prefer, I can rename it.
Ok, let's keep it like this, as clock is ticking :timer_clock:
Something else @kernicPanel, Could you please check the logs of the test step? The react sdk for jitsi is not transpiled, and that makes the tests to crash on the demo. Have you an idea on how to solve that ? Thank you
@jbpenrath found the solution !
In src/frontend/demo/jest.config.js
:
// import type { Config } from "@jest/types";
module.exports = {
verbose: true,
transform: {
'^.+\\.(ts|tsx|js|jsx)$': 'ts-jest',
},
moduleNameMapper: {
'\\.(css|less|scss|sss|styl)$': 'jest-css-modules',
'@jitsi-magnify/core': `<rootDir>/../magnify/src/index.ts`,
},
testEnvironment: 'jsdom',
setupFilesAfterEnv: ['./jest-setup.ts'],
moduleDirectories: ['node_modules', 'src'],
transformIgnorePatterns: ['node_modules/(?!@jitsi/react-sdk)'],
};
Thank you a lot. It works indeed.
Purpose
This create a view for the jitsi iframe, including a disambiguation screen at the beginning if there are more than 1 meeting in progress