openfun / jitsi-magnify

An authentication and room management system for Jitsi built with Django/React
MIT License
23 stars 6 forks source link

Create jitsi view #68

Closed Leonils closed 2 years ago

Leonils commented 2 years ago

Purpose

This create a view for the jitsi iframe, including a disambiguation screen at the beginning if there are more than 1 meeting in progress

Screenshot from 2022-07-11 17-57-11 Screenshot from 2022-07-11 17-56-49

kernicPanel commented 2 years ago

Could you please rebase ? The conflicts seems easy to solve.

Leonils commented 2 years ago

About the Disambiguation, it should not be visible too often, but only when we have a doubt on what the user want to do, for instance if there are 2 meetings at the same time, of very close, so the name. But if you prefer, I can rename it.

Leonils commented 2 years ago

Something else @kernicPanel, Could you please check the logs of the test step? The react sdk for jitsi is not transpiled, and that makes the tests to crash on the demo. Have you an idea on how to solve that ? Thank you

kernicPanel commented 2 years ago

About the Disambiguation, it should not be visible too often, but only when we have a doubt on what the user want to do, for instance if there are 2 meetings at the same time, of very close, so the name. But if you prefer, I can rename it.

Ok, let's keep it like this, as clock is ticking :timer_clock:

kernicPanel commented 2 years ago

Something else @kernicPanel, Could you please check the logs of the test step? The react sdk for jitsi is not transpiled, and that makes the tests to crash on the demo. Have you an idea on how to solve that ? Thank you

@jbpenrath found the solution ! In src/frontend/demo/jest.config.js:

// import type { Config } from "@jest/types";

module.exports = {
  verbose: true,
  transform: {
    '^.+\\.(ts|tsx|js|jsx)$': 'ts-jest',
  },
  moduleNameMapper: {
    '\\.(css|less|scss|sss|styl)$': 'jest-css-modules',
    '@jitsi-magnify/core': `<rootDir>/../magnify/src/index.ts`,
  },
  testEnvironment: 'jsdom',
  setupFilesAfterEnv: ['./jest-setup.ts'],
  moduleDirectories: ['node_modules', 'src'],
  transformIgnorePatterns: ['node_modules/(?!@jitsi/react-sdk)'],
};
Leonils commented 2 years ago

Thank you a lot. It works indeed.