openfun / joanie

👛 A headless ERP for education to manage course enrollment/subscription, payment and certificates delivery.
MIT License
20 stars 2 forks source link

Contract - Improve name of contract uploaded on Signature Provider #729

Closed jbpenrath closed 3 months ago

jbpenrath commented 3 months ago

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe. Currently, contract document uploaded on our Signature Provider are named with the contract definition template name. That's weird as for a training all contracts have the same name (e.g: contract-definition-0.pdf

Describe the solution you'd like

We could improve this name by joining relevant information as contract creation_date, username organization code and course code or product relation id ?

The purpose of prefixing document name by date with the format YYYY-MM-DD is to allow user to easily sort documents by date once downloaded.

YYYY-MM-DD_USERNAME_ORG-CODE_COURSE-CODE.pdf or YYYY-MM-DD_USERNAME_ORG-CODE_RELATION-ID.pdf

e.g: 2024-04-04_johndoe_ORG001_178001.pdf 2024-04-04_johndoe_ORG001_50502e74-c0f4-4387-936c-8e37f82bd7c2.pdf

jbpenrath commented 3 months ago

Finally to prevent to bind user or organization information, I decided to use the following format : YYYY-MM-DD_COURSE-CODE_ORDER_PK.pdf