openfun / joanie

👛 A headless ERP for education to manage course enrollment/subscription, payment and certificates delivery.
MIT License
20 stars 2 forks source link

♻️(backend) refactor terms and conditions for contract #831

Closed jonathanreveille closed 3 weeks ago

jonathanreveille commented 3 weeks ago

Purpose

From now on, the terms and conditions (CGV in french) must be specific for every organization. This means we can't have a global one for the whole platform. The terms and conditions will be injected into the contract's context, so the Order model does need to track down if the user has accepted those, since he will accept them while signing the contract.

Proposal

lunika commented 3 weeks ago

You have 3 items in your proposal but only one commit. This is not logical. You should split in 3 different commits.

jbpenrath commented 3 weeks ago

⚠️ You must merge this PR into https://github.com/openfun/joanie/tree/dev branch not https://github.com/openfun/joanie/tree/main !