openfun / marsha

:clapper: An opensource LTI Learning Content Management System (LCMS)
MIT License
107 stars 24 forks source link

✨ replace grommet select by cunningham select #2400

Closed AntoLC closed 11 months ago

AntoLC commented 1 year ago

Purpose

Replace partially grommet select by cunningham select.

The Cunnigham Select doesn't fit all our needs, but we can still replace a part of the select. This PR helps us as well to identify our different needs, an feature request issue has been opened alongside this PR: https://github.com/openfun/cunningham/issues/155

Proposal

Select left

. LanguagePicker : We need an icon on the left of the select. . useSelectPlaylist: We need the virtualization - We can have lot of playlist . RenaterAuthenticator: We need options with JSX.Element[] type . SchedulingFields: We need suggestion prop, to start the scroll to a specific value and searchableFree prop, to search a potential value but let as well the possibility to use the value taped by the user (see example)

AntoLC commented 1 year ago

We need this issue to be resolved with a new cunningham version before we can merge this PR.

A PR has been submitted: https://github.com/openfun/cunningham/pull/158, when merge and release we will be able to adapt this PR to be mergeable.

AntoLC commented 12 months ago

The translations in french have to be review, maybe I should change the id of the ones I updated?

When english language is set: scrnli_9_13_2023_10-25-43 AM

When french language is set: scrnli_9_13_2023_10-26-02 AM

lunika commented 12 months ago

The translations in french have to be review, maybe I should change the id of the ones I updated?

When english language is set: scrnli_9_13_2023_10-25-43 AM

When french language is set: scrnli_9_13_2023_10-26-02 AM

I will do that on crowdin :+1: