search

openfun / marsha

:clapper: An opensource LTI Learning Content Management System (LCMS)
MIT License
106 stars 24 forks source link

♻️(standalone_site) replace grommet Box component #2479

Closed AntoLC closed 8 months ago

AntoLC commented 9 months ago

Purpose

On standalone site only

In order to do the transition to the cunningham design system, we replace the grommet Box component.

Proposal

kernicPanel commented 9 months ago

I see a problem with the menu (probably related to the fact that the boxes are not replaced in packages for now)

https://github.com/openfun/marsha/assets/720491/d938e775-c60e-4998-a939-608acc2c80d8

AntoLC commented 9 months ago

I see a problem with the menu (probably related to the fact that the boxes are not replaced in packages for now)

menu_overflow.mp4

I don't reproduce (Firefox / Chrome).

AntoLC commented 8 months ago

I have a white block at the top of the document as you can see on this screenshot

Screenshot 2023-10-30 at 14-55-24 Marsha

The footer color is not the same between master and your branch

Screenshot from 2023-10-30 15-03-08

I don't reproduce the white block when I am totally on the top.

About the color footer: https://github.com/openfun/marsha/pull/2479/commits/4f8a6728031ea15093e15ffc4c01136890d50fd2