search

openfun / marsha

:clapper: An opensource LTI Learning Content Management System (LCMS)
MIT License
104 stars 24 forks source link

♻️(frontend) replace grommet TextArea with cunningham TextArea #2500

Closed AntoLC closed 7 months ago

AntoLC commented 8 months ago

Purpose

In order to do the transition to the cunningham design system, we replace the grommet TextArea component with the cunningham TextArea components.

Proposal

AntoLC commented 7 months ago

Fixes:

  • You have modified the color used in the input type text, it is black now and I don't where it has been changed in this PR... but in master it's the good color image

Yes, fix here: https://github.com/openfun/marsha/pull/2500/commits/5e2bfaa8df0da0e9dbbebe1e0eecc234dc1d11c7#diff-522e0e6a642a595b19b95b239ee5df0f4546d578b792267534b2abe33c29bb00R85

  • In the commit 🐛(lib-classroom) fix description update from another user you mention the websocket but no websocket is used for the classroom resource.

I replace websocket by polling in the commit description: https://github.com/openfun/marsha/pull/2500/commits/4c60279bfe878f71b59b217018d894830ede243d

I fixed the box out of screen in this commit: https://github.com/openfun/marsha/pull/2500/commits/5ac99fa4d9668c6d7cd7455d68a299a4beb7938a

image