openfun / marsha

:clapper: An opensource LTI Learning Content Management System (LCMS)
MIT License
104 stars 24 forks source link

🐛(lib-video) fix display issues with picture shared ressource in live #2508

Closed AntoLC closed 7 months ago

AntoLC commented 7 months ago

Purpose

(live) glitch d'affichage du partage de documents en mode fenĂȘtrĂ© sur navigateur.

https://trello.com/1/cards/654b8ab615e123d2213a9c9a/attachments/655347173d05e4332536b0e1/download/Partage_de_document_-_responsiveness.webm

https://trello.com/1/cards/654b8ab615e123d2213a9c9a/attachments/65534793bf00d478bfc1589f/download/Partage_de_document_-_responsiveness_02.webm

Fixed

Observation

The width of the vignette is limited here: https://github.com/openfun/marsha/blob/d55f4d5e95c075291f2a27e775f8a65f363b7f36/src/frontend/packages/lib_video/src/conf/pictureInPicture.ts#L3

It could have been nice to increase to 0.8, but we get a responsive problem with the height, it asks a not so small refacto to be able to make it works correctly.