openfun / marsha

:clapper: An opensource LTI Learning Content Management System (LCMS)
MIT License
106 stars 24 forks source link

(live) improve UX for document sharing #2511

Closed NamFra closed 10 months ago

NamFra commented 10 months ago

Bug Report

Problematic Behavior The SharedLiveMedia widget has been redesigned, and document sharing and download permissions are now presented more explicitly.

Then

It was necessary to first Stop sharing the current document to display another one (option grayed out).

image

Now

It is now possible to activate the switch for another document while another document is currently being shared.

image

Expected behavior/code Using the switch on another document should disable the active document without generating an error.

Steps to Reproduce

  1. Create a webinar
  2. Add 2 files using the document sharing widget
  3. Activate the share support switch on one document
  4. Activate the switch on the other document without deactivating the first one
  5. See the error 'Share media update has failed !'"

Environment

Additional context/Screenshots https://github.com/openfun/marsha/blob/master/src/frontend/packages/lib_video/src/components/common/VideoWidgetProvider/widgets/SharedLiveMedia/index.spec.tsx

live-shared-media-failed.webm