openfun / openedx-docker

:whale: A best practice Docker image of Open edX
https://hub.docker.com/r/fundocker/edxapp
GNU Affero General Public License v3.0
129 stars 75 forks source link

🔒️(all) set session cookie secure to True as default #300

Closed sampaccoud closed 3 years ago

sampaccoud commented 3 years ago

Purpose

We relied on OpenEdX's default value for the SESSION_COOKIE_SECURE setting but it is unsecure.

Proposal

Directly use True as default value for the SESSION_COOKIE_SECURE setting.

sampaccoud commented 3 years ago

@jmaupetit dogwood.3.bare won't build anymore so I proposed to remove it...

jmaupetit commented 3 years ago

@jmaupetit dogwood.3.bare won't build anymore so I proposed to remove it...

Do it! :fire: