search

openfun / potsie

:bar_chart: Grafana dashboards suite for learning analytics
https://demo.potsie.education
MIT License
10 stars 2 forks source link

Fix ES queries aggregation max size #52

Closed jmaupetit closed 2 years ago

jmaupetit commented 2 years ago

Purpose

Choosing a query grouping size to 'no-limit' sets it to 500 in the generated Elasticsearch query. This is a strong limitation for our metrics as some unique counters (such as views) may be higher than that on large analysis periods.

Proposal

To mitigate this issue, we give us some space by settings it to the maximal allowed value for our Elasticsearch cluster, e.g. 10000.

jmaupetit commented 2 years ago

Looking for a smarter solution.

quitterie-lcs commented 2 years ago

@jmaupetit ready for a review! With a proper solution

quitterie-lcs commented 2 years ago

@jmaupetit fixed