search

openfun / richie

:pencil: An opensource CMS to build education portals
https://richie.education
MIT License
259 stars 83 forks source link

⬆️(all) upgrade node to version 20 #2271

Closed jbpenrath closed 7 months ago

jbpenrath commented 7 months ago

Purpose

Some CircleCI jobs are failing as node 20 is required.

Node 20 is now the LTS version and some frontend dependencies requires node>=20, so we upgrade the whole codebase to the node LTS version.

Proposal

jbpenrath commented 7 months ago

I found two missing reference to node 18.19.0 i don't know if it's matter to update this yarn.lock file.

$ git grep '18\.19'
cookiecutter/{{cookiecutter.organization}}-richie-site-factory/template/{{cookiecutter.site}}/src/frontend/yarn.lock:  version "18.19.8"
cookiecutter/{{cookiecutter.organization}}-richie-site-factory/template/{{cookiecutter.site}}/src/frontend/yarn.lock:  resolved "https://registry.yarnpkg.com/@types/node/-/node-18.19.8.tgz#c1e42b165e5a526caf1f010747e0522cb2c9c36a"

Otherwise, it's all good !

I ran an yarn install and the yarn.lock hasn't been updated so I assume that is ok.