opengamedata / opengamedata-core

Python framework for extracting features from OpenGameData event datasets.
https://opengamedata.fielddaylab.wisc.edu/
MIT License
1 stars 3 forks source link

Move primary Extractor-loading logic from "Loader" to "Registry" #43

Closed LswaN58 closed 1 year ago

LswaN58 commented 1 year ago

Really, the loader should just know how to load individual extractors. The registry is the active thing here, with Feature and Detector subclasses, so it should have the logic for looping over appropriate set of defs from GameSchema and loading + registering them.

LswaN58 commented 1 year ago

Initially implemented with 4dbd6d455f3298b435df5ee14265091db7afb49c, finished bugfixing with 41f483be4e726632ccf92ea241cd281e235fc37c