opengapps / aosp_build

AOSP Build system compatible version of Open GApps
GNU General Public License v3.0
318 stars 155 forks source link

opengapps build issue on android-x86 #162

Closed James6xie closed 6 years ago

James6xie commented 6 years ago

Hi Guys! I added opengapps to my android-x86 repo ,what i did as below: 1.Add the build system, and the wanted sources to your manifest. 2.GAPPS_VARIANT := stock

  1. add $(call inherit-product, vendor/opengapps/build/opengapps-packages.mk) in device/generic/common/device.mk

but build cann't success,output as below:

[ 38% 20140/52832] target Package: DownloadProviderUi (out/target/product/x86_64/obj/APPS/DownloadProviderUi_intermediates/package.apk)
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c mdpi-v4. Use --preferred-density instead.
warning: ignoring flag -c hdpi-v4. Use --preferred-density instead.
[ 38% 20151/52832] Docs droiddoc: out/target/common/docs/apache-http-stubs-gen
external/apache-http/../../frameworks/base/core/java/android/net/http/SslCertificate.java:19: error: cannot find symbol
import com.android.internal.util.HexDump;
                                ^
  symbol:   class HexDump
  location: package com.android.internal.util
external/apache-http/../../frameworks/base/core/java/android/net/http/SslCertificate.java:42: error: package com.android.org.bouncycastle.asn1.x509 does not exist
import com.android.org.bouncycastle.asn1.x509.X509Name;
                                             ^
external/apache-http/../../frameworks/base/core/java/android/net/http/HttpResponseCache.java:19: error: package com.android.okhttp does not exist
import com.android.okhttp.Cache;
                         ^
external/apache-http/../../frameworks/base/core/java/android/net/http/HttpResponseCache.java:20: error: package com.android.okhttp does not exist
import com.android.okhttp.AndroidShimResponseCache;
                         ^
external/apache-http/../../frameworks/base/core/java/android/net/http/HttpResponseCache.java:21: error: package com.android.okhttp does not exist
import com.android.okhttp.OkCacheContainer;
                         ^
external/apache-http/../../frameworks/base/core/java/android/net/http/HttpResponseCache.java:152: error: cannot find symbol
public final class HttpResponseCache extends ResponseCache implements Closeable, OkCacheContainer {
                                                                                 ^
  symbol: class OkCacheContainer
external/apache-http/../../frameworks/base/core/java/android/net/http/HttpResponseCache.java:154: error: cannot find symbol
    private final AndroidShimResponseCache delegate;
                  ^
  symbol:   class AndroidShimResponseCache
  location: class HttpResponseCache
external/apache-http/../../frameworks/base/core/java/android/net/http/HttpResponseCache.java:156: error: cannot find symbol
    private HttpResponseCache(AndroidShimResponseCache delegate) {
                              ^
  symbol:   class AndroidShimResponseCache
  location: class HttpResponseCache
external/apache-http/../../frameworks/base/core/java/android/net/http/HttpResponseCache.java:296: error: cannot find symbol
    public Cache getCache() {
           ^
  symbol:   class Cache
  location: class HttpResponseCache
Canvas.java:0: warning 113: Method android.graphics.Canvas.clipRegion: @Deprecated annotation and @deprecated doc tag do not match
Canvas.java:0: warning 113: Method android.graphics.Canvas.drawBitmap: @Deprecated annotation and @deprecated doc tag do not match
Canvas.java:0: warning 113: Method android.graphics.Canvas.

i search on google it said https://thealaskalinuxuser.wordpress.com/2017/05/16/yet-again-error-package-com-android-okhttp-does-not-exist/

I add +LOCAL_JAVA_LIBRARIES := $(apache_http_java_libs) okhttp bouncycastle framework but also cann't build success, ouput as below:

including ./vendor/opengapps/build/modules/talkback/Android.mk ...
build/core/binary.mk:925: warning: overriding commands for target `out/target/product/x86_64/obj/STATIC_LIBRARIES/libv8_intermediates/src/base/atomicops_internals_x86_gcc.o'
build/core/binary.mk:925: warning: ignoring old commands for target `out/target/product/x86_64/obj/STATIC_LIBRARIES/libv8_intermediates/src/base/atomicops_internals_x86_gcc.o'
build/core/binary.mk:925: warning: overriding commands for target `out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libv8_intermediates/src/base/atomicops_internals_x86_gcc.o'
build/core/binary.mk:925: warning: ignoring old commands for target `out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libv8_intermediates/src/base/atomicops_internals_x86_gcc.o'
Starting build with ninja
ninja: Entering directory `.'
[  0% 11/32093] target Prebuilt: GoogleCamera (out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk)
FAILED: /bin/bash -c "(out/host/linux-x86/bin/acp -fp  out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk ) && (if (zipinfo out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then rm -rf out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/uncompressedlibs && mkdir out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/uncompressedlibs; unzip out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk 'lib/*.so' -d out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/uncompressedlibs && zip -d out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk 'lib/*.so' && ( cd out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/uncompressedlibs && find lib -type f | sort | zip -D -X -0 ../package.apk -@ ) && rm -rf out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/uncompressedlibs; fi ) && (if ! out/host/linux-x86/bin/zipalign -c -p 4 out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk >/dev/null ; then mv out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk.unaligned; out/host/linux-x86/bin/zipalign -f -p 4 out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk.unaligned out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk.aligned; mv out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk.aligned out/target/product/x86_64/obj/APPS/GoogleCamera_intermediates/package.apk; fi )"
acp: missing destination file
[  0% 11/32093] Ensure Jack server is installed and started
Jack server already installed in "/home/chaozhuoxzt/.jack-server"
Server is already running
[  0% 11/32093] Docs droiddoc: out/target/common/docs/apache-http-stubs-gen
Canvas.java:0: warning 113: Method android.graphics.Canvas.clipRegion: @Deprecated annotation and @deprecated doc tag do not match
Canvas.java:0: warning 113: Method android.graphics.Canvas.drawBitmap: @Deprecated annotation and @deprecated doc tag do not match
Canvas.java:0: warning 113: Method android.graphics.Canvas.drawPosText: @Deprecated annotation and @deprecated doc tag do not match
Canvas.java:0: warning 113: Method android.graphics.Canvas.getMatrix: @Deprecated annotation and @deprecated doc tag do not match
Character.java:0: warning 113: Method java.lang.Character.isJavaLetter: @Deprecated annotation and @deprecated doc tag do not match
Character.java:0: warning 113: Method java.lang.Character.isJavaLetterOrDigit: @Deprecated annotation and @deprecated doc tag do not match
Character.java:0: warning 113: Method java.lang.Character.isSpace: @Deprecated annotation and @deprecated doc tag do not match
ClassLoader.java:0: warning 113: Method java.lang.ClassLoader.defineClass: @Deprecated annotation and @deprecated doc tag do not match
ContentObserver.java:0: warning 113: Method android.database.ContentObserver.dispatchChange: @Deprecated annotation and @deprecated doc tag do not match
ContentResolver.java:0: warning 113: Method android.content.ContentResolver.cancelSync: @Deprecated annotation and @deprecated doc tag do not match
ContentResolver.java:0: warning 113: Method android.content.ContentResolver.getCurrentSync: @Deprecated annotation and @deprecated doc tag do not match
ContentResolver.java:0: warning 113: Method android.content.ContentResolver.startSync: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.clearWallpaper: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.getWallpaper: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.getWallpaperDesiredMinimumHeight: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.getWallpaperDesiredMinimumWidth: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.peekWallpaper: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.removeStickyBroadcast: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.removeStickyBroadcastAsUser: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.sendStickyBroadcast: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.sendStickyBroadcastAsUser: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.sendStickyOrderedBroadcast: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.sendStickyOrderedBroadcastAsUser: @Deprecated annotation and @deprecated doc tag do not match
Context.java:0: warning 113: Method android.content.Context.setWallpaper: @Deprecated annotation and @deprecated doc tag do not match
Cursor.java:0: warning 113: Method android.database.Cursor.deactivate: @Deprecated annotation and @deprecated doc tag do not match
Cursor.java:0: warning 113: Method android.database.Cursor.requery: @Deprecated annotation and @deprecated doc tag do not match
DatagramSocketImpl.java:0: warning 113: Method java.net.DatagramSocketImpl.getTTL: @Deprecated annotation and @deprecated doc tag do not match
DatagramSocketImpl.java:0: warning 113: Method java.net.DatagramSocketImpl.setTTL: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.UTC: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getDate: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getDay: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getHours: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getMinutes: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getMonth: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getSeconds: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getTimezoneOffset: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.getYear: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.parse: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.setDate: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.setHours: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.setMinutes: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.setMonth: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.setSeconds: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.setYear: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.toGMTString: @Deprecated annotation and @deprecated doc tag do not match
Date.java:0: warning 113: Method java.util.Date.toLocaleString: @Deprecated annotation and @deprecated doc tag do not match
Display.java:0: warning 113: Method android.view.Display.getHeight: @Deprecated annotation and @deprecated doc tag do not match
Display.java:0: warning 113: Method android.view.Display.getOrientation: @Deprecated annotation and @deprecated doc tag do not match
Display.java:0: warning 113: Method android.view.Display.getPixelFormat: @Deprecated annotation and @deprecated doc tag do not match
Display.java:0: warning 113: Method android.view.Display.getWidth: @Deprecated annotation and @deprecated doc tag do not match
File.java:0: warning 113: Method java.io.File.toURL: @Deprecated annotation and @deprecated doc tag do not match
Intent.java:0: warning 113: Method android.content.Intent.getIntent: @Deprecated annotation and @deprecated doc tag do not match
Intent.java:0: warning 113: Method android.content.Intent.toURI: @Deprecated annotation and @deprecated doc tag do not match
IntentSender.java:0: warning 113: Method android.content.IntentSender.getTargetPackage: @Deprecated annotation and @deprecated doc tag do not match
PackageManager.java:0: warning 113: Method android.content.pm.PackageManager.addPackageToPreferred: @Deprecated annotation and @deprecated doc tag do not match
PackageManager.java:0: warning 113: Method android.content.pm.PackageManager.addPreferredActivity: @Deprecated annotation and @deprecated doc tag do not match
PackageManager.java:0: warning 113: Method android.content.pm.PackageManager.removePackageFromPreferred: @Deprecated annotation and @deprecated doc tag do not match
Paint.java:0: warning 113: Method android.graphics.Paint.getRasterizer: @Deprecated annotation and @deprecated doc tag do not match
Paint.java:0: warning 113: Method android.graphics.Paint.setRasterizer: @Deprecated annotation and @deprecated doc tag do not match
Picture.java:0: warning 113: Method android.graphics.Picture.createFromStream: @Deprecated annotation and @deprecated doc tag do not match
Picture.java:0: warning 113: Method android.graphics.Picture.writeToStream: @Deprecated annotation and @deprecated doc tag do not match
Properties.java:0: warning 113: Method java.util.Properties.save: @Deprecated annotation and @deprecated doc tag do not match
SQLiteClosable.java:0: warning 113: Method android.database.sqlite.SQLiteClosable.onAllReferencesReleasedFromContainer: @Deprecated annotation and @deprecated doc tag do not match
SQLiteClosable.java:0: warning 113: Method android.database.sqlite.SQLiteClosable.releaseReferenceFromContainer: @Deprecated annotation and @deprecated doc tag do not match
SQLiteDatabase.java:0: warning 113: Method android.database.sqlite.SQLiteDatabase.getSyncedTables: @Deprecated annotation and @deprecated doc tag do not match
SQLiteDatabase.java:0: warning 113: Method android.database.sqlite.SQLiteDatabase.isDbLockedByOtherThreads: @Deprecated annotation and @deprecated doc tag do not match
SQLiteDatabase.java:0: warning 113: Method android.database.sqlite.SQLiteDatabase.markTableSyncable: @Deprecated annotation and @deprecated doc tag do not match
SQLiteDatabase.java:0: warning 113: Method android.database.sqlite.SQLiteDatabase.setLockingEnabled: @Deprecated annotation and @deprecated doc tag do not match
SQLiteDatabase.java:0: warning 113: Method android.database.sqlite.SQLiteDatabase.yieldIfContended: @Deprecated annotation and @deprecated doc tag do not match
SQLiteProgram.java:0: warning 113: Method android.database.sqlite.SQLiteProgram.getUniqueId: @Deprecated annotation and @deprecated doc tag do not match
String.java:0: warning 113: Method java.lang.String.getBytes: @Deprecated annotation and @deprecated doc tag do not match
Thread.java:0: warning 113: Method java.lang.Thread.countStackFrames: @Deprecated annotation and @deprecated doc tag do not match
Thread.java:0: warning 113: Method java.lang.Thread.destroy: @Deprecated annotation and @deprecated doc tag do not match
Thread.java:0: warning 113: Method java.lang.Thread.resume: @Deprecated annotation and @deprecated doc tag do not match
Thread.java:0: warning 113: Method java.lang.Thread.stop: @Deprecated annotation and @deprecated doc tag do not match
Thread.java:0: warning 113: Method java.lang.Thread.suspend: @Deprecated annotation and @deprecated doc tag do not match
ThreadGroup.java:0: warning 113: Method java.lang.ThreadGroup.allowThreadSuspension: @Deprecated annotation and @deprecated doc tag do not match
ThreadGroup.java:0: warning 113: Method java.lang.ThreadGroup.resume: @Deprecated annotation and @deprecated doc tag do not match
ThreadGroup.java:0: warning 113: Method java.lang.ThreadGroup.stop: @Deprecated annotation and @deprecated doc tag do not match
ThreadGroup.java:0: warning 113: Method java.lang.ThreadGroup.suspend: @Deprecated annotation and @deprecated doc tag do not match
URLConnection.java:0: warning 113: Method java.net.URLConnection.getDefaultRequestProperty: @Deprecated annotation and @deprecated doc tag do not match
URLConnection.java:0: warning 113: Method java.net.URLConnection.setDefaultRequestProperty: @Deprecated annotation and @deprecated doc tag do not match
URLStreamHandler.java:0: warning 113: Method java.net.URLStreamHandler.setURL: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/android/src/com/android/internal/http/multipart/Part.java:61: warning 113: Field com.android.internal.http.multipart.Part.BOUNDARY: @Deprecated annotation and @deprecated comment do not match
external/apache-http/android/src/com/android/internal/http/multipart/Part.java:67: warning 113: Field com.android.internal.http.multipart.Part.BOUNDARY_BYTES: @Deprecated annotation and @deprecated comment do not match
external/apache-http/android/src/com/android/internal/http/multipart/Part.java:128: warning 113: Method com.android.internal.http.multipart.Part.getBoundary: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/codec/language/Soundex.java:194: warning 113: Method org.apache.commons.codec.language.Soundex.getMaxLength: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/codec/language/Soundex.java:231: warning 113: Method org.apache.commons.codec.language.Soundex.setMaxLength: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/codec/net/URLCodec.java:356: warning 113: Method org.apache.commons.codec.net.URLCodec.getEncoding: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/logging/impl/LogFactoryImpl.java:513: warning 113: Method org.apache.commons.logging.impl.LogFactoryImpl.getLogClassName: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/logging/impl/LogFactoryImpl.java:538: warning 113: Method org.apache.commons.logging.impl.LogFactoryImpl.getLogConstructor: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/logging/impl/LogFactoryImpl.java:556: warning 113: Method org.apache.commons.logging.impl.LogFactoryImpl.isJdk13LumberjackAvailable: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/logging/impl/LogFactoryImpl.java:572: warning 113: Method org.apache.commons.logging.impl.LogFactoryImpl.isJdk14Available: @Deprecated annotation and @deprecated doc tag do not match
external/apache-http/src/org/apache/commons/logging/impl/LogFactoryImpl.java:585: warning 113: Method org.apache.commons.logging.impl.LogFactoryImpl.isLog4JAvailable: @Deprecated annotation and @deprecated doc tag do not match
DroidDoc took 1 sec. to write docs to out/target/common/docs/apache-http-stubs-gen
ninja: build stopped: subcommand failed.
build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
make: *** [ninja_wrapper] Error 1
make: Leaving directory '/data/androidx86'
jamuir commented 6 years ago

the first error you hit doesn't seem to have anything to do with open gapps.

are you able to build an android-x86 image successfully without open-gapps?

the second error you hit (Google Camera) says there is a missing file. Maybe your build is in a bad state.

Try running make installclean and building again.

James6xie commented 6 years ago

OK,what i'do as below:

  1. first i build an android-x86 img successfully without open-gapps; 2.secondly i add open-gapps repo to local_manifest/opengapps.xml (as below:) and exec repo sync cmd successfully;

    /data/androidx86$ cat .repo/local_manifests/opengapps.xml <?xml version="1.0" encoding="UTF-8"?>


  2. Then i add makefile config to device/generic/common/device.mk

    /data/androidx86/device/generic/common$ git diff diff --git a/device.mk b/device.mk index 3764464..5288a27 100644 --- a/device.mk +++ b/device.mk @@ -13,6 +13,23 @@

    See the License for the specific language governing permissions and

    limitations under the License.

    # +GAPPS_VARIANT := pico +PRODUCT_PACKAGES += Chrome \

    • KeyboardGoogle \
    • LatinImeGoogle \
    • GoogleTTS \
    • YouTube \
    • PixelIcons \
    • PixelLauncher \
    • Wallpapers \
    • PixelLauncherIcons \
    • WebViewGoogle \
    • GoogleServicesFramework \
    • GoogleLoginService \ +GAPPS_FORCE_BROWSER_OVERRIDES := true
    • +GAPPS_EXCLUDED_PACKAGES := FaceLock \

    • AndroidPlatformServices \

    PRODUCT_DIR := $(dir $(lastword $(filter-out device/common/%,$(filter device/%,$(ALL_PRODUCTS)))))

@@ -111,3 +128,6 @@ $(call inherit-product-if-exists,vendor/google/products/ gms.mk)

Get native bridge settings

$(call inherit-product-if-exists,$(LOCAL_PATH)/nativebridge/nativebridge.mk ) + +#Opengapps +$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)

Finally, run m -j8 iso_img to build open-apps to android-x86 img;

2018-01-15 22:49 GMT+08:00 James Muir notifications@github.com:

the first error you hit doesn't seem to have anything to do with open gapps.

are you able to build an android-x86 image successfully without open-gapps?

the second error you hit (Google Camera) says there is a missing file. Maybe your build is in a bad state.

Try running make installclean and building again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opengapps/aosp_build/issues/162#issuecomment-357703307, or mute the thread https://github.com/notifications/unsubscribe-auth/APzj-aimLLCqFYbTr6nKfr91lYEk5v7Yks5tK2VogaJpZM4ReG0j .

jamuir commented 6 years ago

Try running make installclean before building with opengapps.

Also, try just building pico (i.e. drop the additional packages you added).

zeevox commented 6 years ago

I have a very similar error. I am also trying to build android-x86.

I have built android-x86 multiple times without error. I added OpenGapps pico package to have minimal conflicts, yet I still get the following error:

[  1% 19/1734] AAPT2 link out/target/product/x86_64/obj/APPS/framework-res_intermediates/package-res.apk
warn: ignoring density 'mdpi-v4' for -c option.
warn: ignoring density 'hdpi-v4' for -c option.
ninja: build stopped: subcommand failed.
17:10:07 ninja failed with: exit status 1

By the looks of it, seems like some sort of conflict with something in framework-res (i.e. frameworks/core/res)

jamuir commented 6 years ago

Could you post more output from your build log? Usually ninja emits the string "FAILED" to indicate where the error is.

zeevox commented 6 years ago

This is what I've added to/device/generic/common/device.mk

$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)
GAPPS_VARIANT := pico

I'm not getting much more from ninja, but I just sent it to build again and here is more output, but a different error this time. Ninja doesn't seem to specify exactly where the error is, unfortunately - is there any way for me to force ninja to output more info about what went wrong?

[ 29% 506/1702] target Prebuilt: PrebuiltGmsCoreInstantApps (out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk)
FAILED: out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk 
/bin/bash -c "(rm -f out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk ) && (cp  out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk ) && (if (zipinfo out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then rm -rf out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/uncompressedlibs && mkdir out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/uncompressedlibs; unzip out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk 'lib/*.so' -d out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/uncompressedlibs && zip -d out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk 'lib/*.so' && ( cd out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/uncompressedlibs && find lib -type f | sort | zip -D -X -0 ../package.apk -@ ) && rm -rf out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/uncompressedlibs; fi ) && (if ! out/host/linux-x86/bin/zipalign -c -p 4 out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk >/dev/null ; then mv out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk.unaligned; out/host/linux-x86/bin/zipalign -f -p 4 out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk.unaligned out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk.aligned; mv out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk.aligned out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk; fi )"
cp: missing destination file operand after 'out/target/product/x86_64/obj/APPS/PrebuiltGmsCoreInstantApps_intermediates/package.apk'
Try 'cp --help' for more information.
ninja: build stopped: subcommand failed.
19:48:50 ninja failed with: exit status 1

Thank you for your help!

jamuir commented 6 years ago

you need to set GAPPS_VARIANT := pico before including the makefile.

Put the following lines at the end of your device.mk file:

GAPPS_VARIANT := pico
$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)
harkaman commented 6 years ago

made build.android x86 face play service stop and play stpre now work/stop. maybe beause of play services I did this First line

#OpenGAPPS
$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)I just build androidx86. I face play services stop and playstore not work. Google chrome works.
#OpenGAPPS
$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)
#OpenGAPPS
GAPPS_VARIANT := pico
PRODUCT_PACKAGES += Chrome \
    KeyboardGoogle \
    LatinImeGoogle \
    GoogleTTS \
    WebViewGoogle \
    GoogleServicesFramework \
    GoogleLoginService \

GAPPS_FORCE_BROWSER_OVERRIDES := true

GAPPS_EXCLUDED_PACKAGES := FaceLock \
    AndroidPlatformServices \
    PrebuiltGmsCoreInstantApps \

at the end.
#OpenGAPPS
$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)
zeevox commented 6 years ago

Thanks for the suggestion! I had some other build errors occur, so I ran make clean and modified the device.mk as suggested. I'll let it run now, my average clean build time is five hours since I'm using a HDD. I'll report back on how it went tomorrow morning (UK).

harkaman commented 6 years ago

I will run another test with First line

OpenGAPPS

GAPPS_VARIANT := pico

GAPPS_FORCE_BROWSER_OVERRIDES := true

GAPPS_EXCLUDED_PACKAGES := FaceLock AndroidPlatformServices PrebuiltGmsCoreInstantApps \

at the end.

OpenGAPPS

$(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)

Hope play service will work. I just built 1 build , but face play service stop issue. That is the only issue i face now. Any sugesstion?

harkaman commented 6 years ago

successfully built. All apps are working. Face play services stop issue in the beginning but when/once I connected to wifi this issue is gone. Play stop work now.

zeevox commented 6 years ago

Thank you for the help, it has now successfully built having placed GAPPS_VARIANT := pico before $(call inherit-product, vendor/opengapps/build/opengapps-packages.mk)

harkaman commented 6 years ago

@ZeevoX DId you need to exclude some of the apps like

GAPPS_EXCLUDED_PACKAGES := FaceLock AndroidPlatformServices PrebuiltGmsCoreInstantApps \

or you did not do this step.

jamuir commented 6 years ago

@ZeevoX : no problem. Glad it worked for you. Thanks for reporting back. :-)

btw, if there is something in the project README.md file that is not clear or not emphasized enough that would have helped your integration go more smoothly, then please let me know and I can make some updates.

@harkaman : in "make", multi-line variable definitions require line-continuation characters. Your assignment to GAPPS_EXCLUDED_PACKAGES isn't correct. Do this instead:

GAPPS_EXCLUDED_PACKAGES := \
  FaceLock \
  AndroidPlatformServices \
  PrebuiltGmsCoreInstantApps

You can also take a look in the file vendor/opengapps/build/opengapps-packages.mk to see some other examples of "make" syntax.

@zhongtianxie : were you able to figure out your build issue?

harkaman commented 6 years ago

@jamuir

when i copy and paste, it did not show all. What I dd it was

GAPPS_EXCLUDED_PACKAGES := FaceLock \
  AndroidPlatformServices \
  PrebuiltGmsCoreInstantApps  \

It built good, no issue at all for me. maybe I could be wrong, but the most important i could build. It is very good and running smooth like butter.

PrebuiltGmsCoreInstantApps was issue when i was building. when i excluded it , then no more issue.

Thanks a lot for helping!