search

opengapps / aosp_build

AOSP Build system compatible version of Open GApps
GNU General Public License v3.0
314 stars 155 forks source link

Build failing because of escape sequence. #251

Open codevalley opened 4 years ago

codevalley commented 4 years ago 
FAILED: out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk
/bin/bash -c "(rm -f out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk ) && (cp \"vendor/opengapps/sources/all/app/com.google.android.markup/29/nodpi/29.apk\" \"out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk\" ) && (if (zipinfo out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then out/soong/host/linux-x86/bin/zip2zip -i out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk -o out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.tmp -0 'lib/**/*.so'  && mv -f out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.tmp out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk ; fi ) && (if ! out/host/linux-x86/bin/zipalign -c  4 out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk >/dev/null ; then mv out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.unaligned; out/host/linux-x86/bin/zipalign -f -p 4 out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.unaligned out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.aligned; mv out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.aligned out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk; fi )"
Unable to open 'out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk' for verification
Unable to open 'out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.unaligned' as zip archive
mv: bad 'out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk.aligned': No such file or directory

This happens further for other packages as well. As I tried to understand what was happening, it looks like the failure is because of escape sequence wrapping of double-quotes. So, rm and cp are failing (I tried to execute each command in that mega command).

$ cp \"vendor/opengapps/sources/all/app/com.google.android.markup/29/nodpi/29.apk\" \"out/target/product/coral/obj/APPS/MarkupGoogle_intermediates/package.apk\"
cp: cannot stat '"vendor/opengapps/sources/all/app/com.google.android.markup/29/nodpi/29.apk"': No such file or directory

Am I doing something wrong here?

stefanhh0 commented 4 years ago

Hello,

~probably following applies as well to your problem: https://github.com/opengapps/aosp_build/issues/253#issuecomment-608232080~

The above is obviously wrong, don't know where the escaping of quotes comes from.

How and what do you build? Standard AOSP or another project?

When I personally build e.g. aosp/sodp as decribed here https://developer.sony.com/develop/open-devices/guides/aosp-build-instructions/build-aosp-android-android-10-0-0 and including opengapps in that build I don't get such escaping issues. That is the only build env I have experience with.

Best regards, Stefan