search

opengds / OpenGDS

Open GOOP Development Suite
MIT License
54 stars 14 forks source link

OpenGDS 1.2.41 (LV2017) GOOP2 -> GOOP3 conversion sometimes deletes class VI's #74

Closed koningsp closed 2 years ago

koningsp commented 2 years ago

The GOOP2 -> GOOP3 conversion sometimes deletes class VI's. ConvertGoop2ToGoop3.vi -> State 'OpenClassesInMemory' a number of specific GOOP2 vi's are deleted. From example the 'class version.vi' containing the 'Class Template Version'. The following file 'class GetProtocolversion.vi' will also get deleted since it match 'Version.vi$'.

image

MikaelHolmstrom commented 2 years ago

Do you have a GOOP2 class I can test with? I've not used GOOP2 for the last 10 years :-)

koningsp commented 2 years ago

See attachment with a simple GOOP2 class. It has two methods that get deleted when I convert it to GOOP3 ('Goop2ToGoop3ConversionTest GetProtocolVersion.vi' and 'Goop2ToGoop3ConversionTest SetProtocolVersion.vi'

I used the old GOOP wizard default so it is an LLB. image

Goop2ToGoop3ConversionTest.zip

koningsp commented 2 years ago

Possible fix: Use the 'ClassPrefix' to get the file correct files. Need to update the Update '\2Evit$' to '.*\2Evit$' to find all VIT of the class

image

MikaelHolmstrom commented 2 years ago

Thanks for you feedback, this is now fixed in version 1.2.81. You can find it in the beta testing listing soon.