search

opengeos / open-buildings

Tools for working with open building datasets
https://opengeos.github.io/open-buildings
Other
119 stars 17 forks source link

Organize packages better #12

Closed cholmes closed 9 months ago

cholmes commented 10 months ago

With the 0.8 release we'll have functions to format overture buildings, and to download any buildings.

I don't really understand how python packages work, but I'd like to get it so the cli.py has 3 subcommands: open_buildings google with convert and benchmark under it - the existing main commands. open_buildings overture with commands to work with overture data. open_buildings tools that has the 'get-buildings' command.

Should likely combine the two overture python files into one. Right now they all have click interfaces in them - the intent was to move all the click interfaces to the cli.py. But once I got into it it would be nice to have some of the commands that were more made for debugging / figuring out what's going (like quad2json, wkt, etc) be in a CLI, but not in the 'main' CLI. So maybe it makes sense to have click packages in both?

I'm also more than open to other ideas on how to organize things. I do think it'll make sense to evolve more of the functions to be 'generic', but I'll make a separate ticket for that.