Open koyo-nic opened 7 months ago
@koyo-nic Thanks for that info. We can remove leafmap if it's not needed.
In terms of testing locally, I've got a fork that I clone and then install open-buildings using python3 setup.py install
There might be other ways to do that I'm not aware of.
Let us know if you need any more help with that.
@mtravis After assessing the main package imports somethings came out clearly. There are packages not included in the main requirements.txt
file but are with in the leafmap
dependencies deptree.
cli.py
: matplotlib pkg usage -> benchmark function
for ploting charts(possiblility of df.plot(kind=bar, rot-0) to something like df.plot.hist().get_figure().savefig('_benchmark.png')
?) not tried out yet. line 136google/stac-geoparquet.py
pystac pkg
So I'd be very cautious before removing the dep. Unless explicitly including the two pkgs in req file to avoid possible missing-module error
Consequently geopandas
installs both pandas & shapely
along with it. At the moment can't figure out clear way to go through with this. but probably after a few local install test i can document something concrete as for the dep cycles.
As for the local install. I wanted to try using pypa modern approach using pyproject.toml
file using either hatch or poetry or rye or flit
tools that's why I spent so much time understanding the depenciesYeah, I think it may make sense to just remove the leafmap stuff to make the whole package a bit simpler. It brings a lot of stuff with it.
Environment Information
Description
Describe what you were trying to get done.
After running installation command
pip install open-buildings
the list of dependencies that pip was installing on the background was suspiciously longer than what would have been expected from therequirements.txt
file. Some packages that would have been expected only when building documentation for example.Based on this message log, I decided to check on the dependencies tree and what package requires these packages i.e
List of all packages Installed
What I Did
Used
pipdeptree
tool to print out the dependency tree for open-buildings package/tool CommandOutput
From the tree output,![image](https://github.com/opengeos/open-buildings/assets/50481279/335aba4e-9e06-4a20-81b3-e3e1eeaac271)
leamap
had the most deps thus a general inspection through the code base to find instances in which the package is being used by using visual studio code text editor searchctrl + shift + f
functionality.It turns out to be used once, in the examples file
download_buildings.ipynb
and no usage in the main package source code. Hence kept asking the question why it is included in the mainrequirements.txt
file instead of just docs requirements.