opengeos / whiteboxR

WhiteboxTools R Frontend
https://whiteboxR.gishub.org
Other
168 stars 30 forks source link

Update Repo URL #107

Closed giswqs closed 1 year ago

giswqs commented 1 year ago

This PR updates all the repo url from giswqs to opengeos. If you cloned the repo previously, it is recommended that you update the Git repo remote URL as follows.

git remote set-url origin https://github.com/opengeos/whiteboxR.git
brownag commented 1 year ago

Hey @giswqs I just noticed the docker container action has not run since update to the repo URL. Just letting you know in case that is unexpected.

giswqs commented 1 year ago

Yes, I need to update the repo URL.

brownag commented 1 year ago

Sorry, looks like it was my doing after all, should have looked closer earlier.

I had set the workflow up so it wouldn't run on my fork brownag/whiteboxR... so that line also needed update of the repo owner to "opengeos"

EDIT: well, it runs up to the point to when it tries to push the result; https://github.com/opengeos/whiteboxR/actions/runs/5207196620/jobs/9394506968

brownag commented 11 months ago

@giswqs The docker-publish.yml action now runs as it should, but fails to upload. It may be looking for secrets for dockerhub or similar?

See recent run e.g. https://github.com/opengeos/whiteboxR/actions/runs/5651766769

giswqs commented 11 months ago

Should it be giswqs/whiteboxR? https://github.com/opengeos/whiteboxR/blob/master/.github/workflows/docker-publish.yml#L44 https://hub.docker.com/r/giswqs/whiteboxr

brownag commented 11 months ago

Yes, probably! Then will also need to correct the README. EDIT: my mistake, the readme also references giswqs/whiteboxr

Should it also be ghcr.io/giswqs/whiteboxR for https://github.com/users/giswqs/packages/container/package/whiteboxr? I can't tell from the error if both uploads fail, or just the dockerhub is failing and it just hasn't got to creating ghcr.io/opengeos/whiteboxR

giswqs commented 11 months ago

Yeah, it is a bit confusion after moving the repo to the opengeos GitHub organization.

For GitHub registry, it should be ghcr.io/opengeos/whiteboxR

For Docker Hub, it should be giswqs/whiteboxR. Docker Hub is no longer free for organizations, and that's why it is still under my personal account.

brownag commented 11 months ago

Ok got it! And that makes sense about the organization account.

I made correction in the YAML file so it should works as you describe: https://github.com/opengeos/whiteboxR/actions/runs/5652062082/job/15311122226 Glad it was a simple fix :)

It is worth making this container and keeping it up to date at least with the CRAN package releases, lots of folks use Docker. Thanks!!

giswqs commented 11 months ago

Great! Thank you for fixing it. I can confirm that both have been updated properly.

https://github.com/opengeos/whiteboxR/pkgs/container/whiteboxr

https://hub.docker.com/r/giswqs/whiteboxr