opengeospatial / CityGML-3.0CM

CityGML 3.0 Conceptional Model
MIT License
89 stars 16 forks source link

Further Typographical and Grammatical Issues #136

Closed TatjanaKutzner closed 4 years ago

TatjanaKutzner commented 4 years ago

In addition to issue #118 the following points should be resolved as well:

p. 6 / p. 9

p. 9

p. 10

p. 11

p. 12

p. 14

p. 19

p. 24

p. 25

p. 26

p. 28

p. 32

p. 33

p. 35

p. 37

p. 41

p. 42

p. 48

p. 109

p. 118

p. 133

p. 135 / p. 137

p. 142

p. 145

p. 153 / p. 246

p. 161

p. 257

p. 278

Chapter 9

Tables 9.1.1. - 9.1.11

Starting from Section 9.2

All Enumeration tables in Chapter 9 (e.g. p. 141)

General points

cmheazel commented 4 years ago

Status August 7, 2020 - fixed issues up through page 48.

TatjanaKutzner commented 4 years ago

The following sub-issues have been implemented in the UML model: p. 118, p. 133, p. 142, p. 145, and p. 161

The other sub-issues do not require updates to the UML model.

cmheazel commented 4 years ago

p. 109 - this reference to ISO 19109 is in a definition exported from the UML model. We make it a point not to modify exported content except when absolutely necessary. Since the section header for this class does include a link to the ISO 19109 citation, an additional link is not essential. Chapter 9 - Corrected the templates for Enumerations, Subclass of, and Stereotypes.

cmheazel commented 4 years ago

Notes for the final draft: Section 9.2 - the EA template allows me to include or omit stereotypes. It does not allow me to filter on stereotype value. I will attempt come up with a tool to strip the Property stereotypes out without corrupting other content. Otherwise this will be a manual editing task. 9.1.1-9.1.11 + 9.2 - the links are generated by the EA templates. Cleanup for the final draft will include testing every link and removing those which do not have a valid target. P 257, 9.1.1-11 - The thick lines appear to be an artifact of the rendering process. They are not in the AsciiDoc source. Will work with OGC staff to locate and remedy the problem. General: review the final draft and make sure the use of language is consistent. We previously agreed to use British English.

cmheazel commented 4 years ago

P135-137, P153 / 246, P257 - these appear to be errors in the manual editing and will be cleaned up in the final draft.

TatjanaKutzner commented 4 years ago

@cmheazel Re "Starting from Section 9.2": Not sure, if you are still working on that task, but chapter 9.1 now contains "rolls" and starting with 9.2 many places in the document contain now "roll names".

cmheazel commented 4 years ago

@TatjanaKutzner I just checked the AsciiDoc on GitHub and all I found was "roll name". However, the term "rolls" was used in the dictionary notes on the three ISO classes I added. They have been fixed.

cmheazel commented 4 years ago

Section 9.2 - I now have a shell script which strips out the stereotype<>. Have added entries in the glossary for all ISO concepts which are not included in the data dictionary. This will enable the links in the ISO data dictionaries which currently do not go anywhere. I'll continue this approach for the rest of the data dictionaries. Note: definitions are needed to go with the terms.

TatjanaKutzner commented 4 years ago

@cmheazel It should be "role name", not "roll name".

cmheazel commented 4 years ago

@TatjanaKutzner Yup. I've fixed it in the AsciiDoc. Just need to fix the UML template.

cmheazel commented 4 years ago

Done