Closed chris-little closed 2 years ago
Ordering of values: Maybe we can add to the first bullet point 'The array elements of "values" represent a D-dimensional N_1 x N_2 x ... x N_D array where elements MUST be ordered in row-major order such that an element specified by indices (n_1, n_2, ..., n_D) has the array location n_1 + N_1 (n_2 + N_2 (... + N_{D-1}*n_D)...)).'
Multiplication of shape numbers: Agreed, we should add '... an array of integers which are the dimension sizes N_1, N_2, ..., N_D that when multiplied together MUST equal the number of elements in "values"'.
axisNames: I would at least add '... of the same length as "shape" such that each string assigns a name to the corresponding dimension.'
Number encoding: Agreed, let's change it to [-(2**53)+1, (2**53)-1]
. I noticed this before but forgot about it.
@joanma747 Are you happy with that?
I'll do a PR for this and add @letmaik and @joanma747 as reviewers
I'm happy with the direction of the suggested changes. Much more clear now!.
Are you including the IETF RFC. as part of the normative references?
Are you including the IETF RFC. as part of the normative references?
yes, this is now in the reference list
PR #114 now merged.
@joanma747 identified several areas of confusion requiring improvements to the text. These have been split into 8 separate sub-issues: