search

opengeospatial / HY_Features

http://opengeospatial.github.io/HY_Features/
Other
8 stars 1 forks source link

Review HTML version of web page. #248

Closed dblodgett-usgs closed 6 years ago

dblodgett-usgs commented 7 years ago

This is for everyone. Please look through the HTML version of the spec and see if anything is amiss.

The zipped draft of the html site is as of pull #247. I just zipped up the figures and html from the standard folder: https://github.com/opengeospatial/HY_Features/tree/master/specification/standard

If you want to update your local fork of the repo, that's the same as this zip. Otherwise, download the zip and open the html file enclosed in it in a browser. Should "just work".

HY_Features_html_draft.zip

dblodgett-usgs commented 7 years ago

Latest draft. HY_Features_html_draft.zip

dblodgett-usgs commented 7 years ago

Thanks @IrinaDornblut for the thorough review. This is looking much better!

Anyone else care to have a go?

Latest html here.

dazzasmith commented 7 years ago

I would like to give it a go, but I can't start until next week. What is the time frame?

dblodgett-usgs commented 7 years ago

Plenty of time.

dazzasmith commented 7 years ago

What's the best way to provide feedback?

dblodgett-usgs commented 7 years ago

However is easiest. Probably just open an issue and enumerate things. If you want to go through the asciidoc, you could also just edit things in line and we can look at a diff in a pull request.

Please don't edit the html though since it is auto generated.

On Aug 12, 2017, at 7:13 AM, dazzasmith notifications@github.com wrote:

What's the best way to provide feedback?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opengeospatial/HY_Features/issues/248#issuecomment-321977399, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbHQ9_MaW5aCVcx6jbSACpyC7bXMzmEks5sXZbogaJpZM4OeVvL.

dazzasmith commented 7 years ago

@dblodgett-usgs I've forked and followed instructions (added upstream etc.) to set up a branch. Then done an intial commit as instructed. I don't see my branch under 'branches' yet on the code page, but perhaps it only appears there after the first pull request? Anyway, let me know if I seem to have done something that needs correcting.

dblodgett-usgs commented 7 years ago

I think you are all good. Adding a commit and opening a pull request is just a way to kind of register with the group that you are working on the document. I just opened a PR with your initial commit in it. As you add commits to your personal fork repository, they will show up in that pull request. Once you are done, we can discuss things as needed over in the PR.