chris-little
commented
9 months ago - Section 3: There is not a single requirement ("shall" statement) in the document, and consequently also no requirements requiring that the standardization target of this document (there is none?) has to conform to a certain specification (such as ISO 19111). Therefore, no normative references should be present. Either move the normative references to the bibliography or add/rephrase those parts that justify the presence of normative references (are those parts "This Temporal Abstract Conceptual Model follows ISO 19111:2019, which is the ISO adoption of OGC 18-005r4. The model is also informed by the W3C Time Ontology in OWL.")). I know that the difference between normative and informative references is not really described in the modular specification, but on this point, it would really be good to follow the ISO practice regarding normative references (https://www.iso.org/sites/directives/current/part2/index.xhtml#_idTextAnchor193). [REJECTED]
- Section 7: In Figure 1, the notation of property ReferenceSystem::dimension is wrong. The property is singlevalued, not multivalued. Therefore, notation "dimension = 1..*" is wrong. A correct notation is "dimension {dimension >= 1}". Consider adding a data type (from ISO 19103) to specify the property further: "dimension: Integer {dimension >= 1}". [DONE]
- Section 7: Regarding Figure 1: According to clause 6, a conceptual model is aimed at finding the correct relationships between the different concepts it described. Apart from the aggregations, the associations in figure 1 are labeled "has a". This does not describe the relationships good enough. This only indicates that there is a relationship, not what the nature of this relationship is. Find proper names for all these associations, e.g. an OrdinalTemporalReferenceSysten "is represented by" one or more Notations. Add also reading directions (⯈). This will definitely aid the reader in understanding the conceptual model. [DONE]
- Section 8.3: The concept "tick" seems to be important, but is not explained properly, and is not present in Clause 4, Annex B or Figure 1. Describe "tick" properly and add it to Figure 1. This will also make it possible to remove the single quotes around "tick" (replace ‘tick’ with tick in the whole document. {DONE} {Figure 1 DONE]
- Sections 7, 8.3, 8.4: 8.3 and 8.4 seem to specify two different kinds of temporal coordinate reference systems, one kind having "discrete integer units of measure which can be subject to integer arithmetic" and another kind having "with a continuous number line and units of measure, which can be subject to the full range of real or floating-point arithmetic". This is not reflected in Figure 1, no specializations of TemporalCoordinateReferenceSystem are present. [REJECTED]