opengeospatial / bblocks-postprocess

0 stars 0 forks source link

integrate tests as richer examples in the slate #3

Closed rob-metalinkage closed 12 months ago

rob-metalinkage commented 1 year ago

To keep Slate clean we want a simple example, but to understand potential we often need to see more complex examples.

Provide a means to view more examples from the tests directly, and access the validation reports.

avillar commented 1 year ago

The way to do it right now is to click on the link in the "this Building Block is valid" banner. Does that suffice?

rob-metalinkage commented 1 year ago

Ahh- thats what happened when I clicked on it in a demo expecting it to go to the definition of valid!

I think somewhere we ought to provide a list of the examples being tested - pull out the description elements of each test with the individual validation status.

avillar commented 1 year ago

Yes, I noticed that in one of your presentations (Tomorrow's Innovations?) :)

The valid in that case refers to validation, not to status; I'm treating both separately (and come to think about it, there's nothing regarding status in the Slate template). Should I just merge both properties (if validation doesn't pass, instead of using another property, just update the status to invalid)?

rob-metalinkage commented 1 year ago

We should use http://www.opengis.net/def/status

and Under Development http%3A//www.opengis.net/def/status/under-development

i will update SOSA bblocks

avillar commented 1 year ago

Ok, I'll merge both conditions (if validationFailed then status = invalid else status = bblockMetadata.status).

avillar commented 1 year ago

BTW, http://www.opengis.net/def/status is actually being used (it is what's provided in the status property in bblock.json, minus the prefix).