search

opengeospatial / cdb-volume-1

Repository for OGC CDB Volume 1
http://www.github.com/opengeospatial/cdb-volume-1
2 stars 2 forks source link

Add bathymetry component equivalents to List of all Raster Material D… #13

Closed RobertRicci closed 3 years ago

RobertRicci commented 3 years ago

Added Bathymetry equivalents to 10.6.3.1. List of all Raster Material Dataset Components

ryanfranz commented 3 years ago

I think this looks good, but is a change that should go into the next minor revision (1.3)

ryanfranz commented 3 years ago

Changes look good to me

DavidFLOR commented 3 years ago

Review in progress; these changes are definitely slated for V1.3; V1.2.0 is now officially frozen and done as I have just finished the freeze/release on the cdb-schema repo

RobertRicci commented 3 years ago

@Ryan, based on your comment today for a pixel default-value for bathymetry, there is a section in the spec that elaborates the read (10.6.3.2.2. Default Read Value) , however the default-value to write is not very clear (10.6.3.2.3. Default Write Value). We can add a statement to this section like, "When the source is missing for a specific pixel value, the default material shall be used - Default_Base_Material(0)."

I just realized that the Defaults.xml calls the default material-> Default_Base_Material, whereas the document refers to using -> Default_Material_Layer (0). Looks like this should be corrected too.

DavidFLOR commented 3 years ago

@RobertRicci Please take a look at these two commits I added and see if they incorporate the recommendations you are making in response to @ryanfranz .

@ryanfranz and @cnreediii please review so we can do this merge and finish the action.

ryanfranz commented 3 years ago

Looks good to me!

RobertRicci commented 3 years ago

I agree with your changes.

DavidFLOR commented 3 years ago

OK, great. @cnreediii we are ready merge pending your awareness of these changes for the draft release notes for CDB V1.3

cnreediii commented 3 years ago

I agree with changes.