search

opengeospatial / ets-citygml30-part2

Other
1 stars 1 forks source link

Configure basic conformance classes #31

Closed dstenger closed 3 months ago

dstenger commented 4 months ago

"Of these seventeen conformance classes, only the Core conformance class is mandatory. All other conformance classes are optional. In the case where a conformance class has a dependency on another conformance class, that conformance class should also be implemented." See https://docs.ogc.org/is/21-006r2/21-006r2.html#conformance-class-section

Shall be added here: https://github.com/opengeospatial/ets-citygml30-part2/blob/0c84a34055b984d9ed1deec4bed2fbce4f4c1623/src/main/config/teamengine/config.xml#L18

dstenger commented 4 months ago

Please enter <conformanceClass>Core Validation</conformanceClass> to the file.

dstenger commented 3 months ago

Core Validation is configured correctly as basic conformance class.

However, to me it is not clear if Global shouldn't also be a mandatory conformance class. The spec e.g. states:

...
6.1. Global Requirements

This chapter defines general requirements which are valid for all Conformance Classes and cannot be derived from the GML schemas.
...

This means, as far as I understand, that the general requirements should also be valid for the Core conformance class.

I created an issue in the issue tracker of the specification to clarify this: https://github.com/opengeospatial/CityGML3.0-GML-Encoding/issues/32

dstenger commented 3 months ago

Given the answer of @3DXScape in https://github.com/opengeospatial/CityGML3.0-GML-Encoding/issues/32#issuecomment-2128267850, I propose to also add Global to the basic conformance classes.

@jiann Can you please also add Global Validation to the config.xml?