search

opengeospatial / ets-citygml30-part2

Other
1 stars 1 forks source link

Improve schema validation tests #32

Closed dstenger closed 3 months ago

dstenger commented 3 months ago

Schema validation tests seem to not do a full schema validation (only a single element is checked).

An example how to implement a full schema validation can be found here: https://github.com/opengeospatial/ets-gml32/blob/master/src/main/java/org/opengis/cite/iso19136/data/XMLSchemaValidationTests.java

All tests requiring full schema validation shall be adjusted accordingly.

dstenger commented 3 months ago

@jiann Can you please check the description of this issue and if you need further information?

jiann commented 3 months ago

Schema validation tests seem to not do a full schema validation (only a single element is checked).

An example how to implement a full schema validation can be found here: https://github.com/opengeospatial/ets-gml32/blob/master/src/main/java/org/opengis/cite/iso19136/data/XMLSchemaValidationTests.java

All tests requiring full schema validation shall be adjusted accordingly.

@dstenger The full schema will validate in GlobalValidation.verifyCityGMLInstanceDoc(). It collects the namespaces defined in the XML file and binds them with the local XSD file and the XSD files are used to create a schema validator that validates multiple schemas together.

The document for this requirement is here : https://docs.ogc.org/is/21-006r2/21-006r2.html#gml-section

dstenger commented 3 months ago

Thank you for the clarification. I confirm that this code executes the full schema validation and mark this issue with invalid.