opengeospatial / ets-citygml30-part2

Other
1 stars 1 forks source link

Re-work implementations of Appearance tests #37

Closed dstenger closed 3 weeks ago

dstenger commented 3 months ago

Abstract Test 11:

Inheritance of gml:AbstractSurfaceType and gml:MultiSurface is not considered.

Abstract Test 12:

Expression //app:textureCoordinates[@ring] seems not to be correct (line 84).

Spec states: "...The textureCoordinates and ring properties of a TexCoordList element form pairs and their order is decisive...."

Schema states:

...
  <element name="TexCoordList" substitutionGroup="app:AbstractTextureParameterization" type="app:TexCoordListType">
    <annotation>
      <documentation>TexCoordList defines texture parameterization using texture coordinates.</documentation>
    </annotation>
  </element>
  <complexType name="TexCoordListType">
    <complexContent>
      <extension base="app:AbstractTextureParameterizationType">
        <sequence>
          <element maxOccurs="unbounded" name="textureCoordinates" type="gml:doubleList">
            <annotation>
              <documentation>Specifies the coordinates of texture used for parameterization. The texture coordinates are provided separately for each LinearRing of the surface geometry object.</documentation>
            </annotation>
          </element>
          <element maxOccurs="unbounded" name="ring" type="anyURI">
            <annotation>
              <documentation>Specifies the URIs that point to the LinearRings that are parameterized using the given texture coordinates.</documentation>
            </annotation>
          </element>
        </sequence>
      </extension>
    </complexContent>
  </complexType>
...

Other expressions shall be checked as well.

Abstract Test 13:

Is not implemented.

jiann commented 2 months ago

Abstract Test 11: Verify that surface data is only applied to surface geometries. The target property of a surface data element therefore only references a subtype of gml:AbstractSurfaceType or a gml:MultiSurface.

Need help to collect Inheritance of gml:AbstractSurfaceType and gml:MultiSurface

dstenger commented 2 months ago

Re-work of abstract test 11 was moved to https://github.com/opengeospatial/ets-citygml30-part2/issues/38.

dstenger commented 1 month ago

@jiann

Abstract Test 12:

I still see the expression "//app:textureCoordinates[@ring]". However, ring is a property and not an attribute. Can you please check this?

dstenger commented 1 month ago

Still, this expression is used in Test E. @jiann Can you please check if that is correct?