search

opengeospatial / ets-gpkg12-nsg

Other
2 stars 5 forks source link

Test NSG_filenameExtension is a duplicate of the test filenameExtension #21

Closed lgoltz closed 6 years ago

lgoltz commented 6 years ago

It must be checked if the test must be updated or can be removed.

lgoltz commented 6 years ago

Requirement: 

NSG Req 1: GeoPackages that contains NSG data SHALL use the “gpkg” file extension.  
They SHALL NOT use the “gpkx” file extension to indicate that they are Extended GeoPackages.

The test asserts exactly this requirement (which does not make much sense as if the first assert is true, the second cannot fail and if the first fails the second is not tested):

https://github.com/opengeospatial/ets-gpkg12-nsg/blob/125a617f54deb831a0a90d54723d6fadcd6e7966/src/main/java/org/opengis/cite/gpkg12/nsg/core/NSG_SQLiteContainerTests.java#L20-L27

This is already tested in ets-gpkg12:

https://github.com/opengeospatial/ets-gpkg12/blob/2c4339bbe554fa55d7c4e2c11543c0626617885d/src/main/java/org/opengis/cite/gpkg12/core/SQLiteContainerTests.java#L125-L131

I propose to remove the test.