search

opengeospatial / ets-gpkg12-nsg

Other
2 stars 5 forks source link

Improve exception message of test dataValidity_gpkg_spatial_ref_sys #27

Closed lgoltz closed 6 years ago

lgoltz commented 6 years ago

Description below is outdated! The comments https://github.com/opengeospatial/ets-gpkg12-nsg/pull/24#issuecomment-394811820 https://github.com/opengeospatial/ets-gpkg12-nsg/pull/24#issuecomment-399154444 does not describe this!

The test org.opengis.cite.gpkg12.nsg.core.NSG_SpatialReferenceSystemsTests #crsDefinitionsTest fails if the crs definition from the GeoPackage under test does not match exactly the description in the specification.

See https://github.com/opengeospatial/ets-gpkg12-nsg/pull/24#issuecomment-394811820 https://github.com/opengeospatial/ets-gpkg12-nsg/pull/24#issuecomment-399154444

Failing crs definition: 

GEOGCS["WGS 84",
  DATUM["WGS_1984",
    SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],
  PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],
  UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AUTHORITY["EPSG","4326"]]

expected is exactly 

GEOGCS["WGS84",
  DATUM["WGS_1984",
    SPHEROID["WGS84",6378137,298.257223563]],
  PRIMEM["Greenwich",0],
  UNIT["degree",0.0174532925199433]]

As the additional authorities does not change the crs definition, the test should not fail.

lgoltz commented 6 years ago

In PR #27 the code was cleaned up and the failure messages was improved for a better understanding.

The test dataValidity_gpkg_spatial_ref_sys fails with https://github.com/opengeospatial/ets-gpkg12-nsg/files/2073521/Gpkg-12-nsg-testCases.zip cause the description of the CRS with srs_id 4326 does not match the description from the specification.

As far as I understand the test is fine and the the GeoPackage should be fixed.

The test does not compare CRS definitions via string comparison as described in #34 (so #34 will we reopened again).