opengeospatial / ets-gpkg12

GeoPackage 1.2 Executable Test Suite
Other
7 stars 10 forks source link

Review list of implemented conformance classes in test report and documentation #37

Closed dstenger closed 6 years ago

lgoltz commented 6 years ago

Configured CCs: https://github.com/opengeospatial/ets-gpkg12/blob/27084850e436846e6811f363ce76db44d549aa8d/src/main/config/teamengine/config.xml#L15-L28

Tests configured in testng.xml https://github.com/opengeospatial/ets-gpkg12/blob/27084850e436846e6811f363ce76db44d549aa8d/src/main/resources/org/opengis/cite/gpkg12/testng.xml#L13-L75

Documentation (site): https://github.com/opengeospatial/ets-gpkg12/blob/master/src/site/markdown/index.md

lgoltz commented 6 years ago

The configuration in the config.xml contains all test configured in the testng.xml.

It seems that the documentation is outdated, the CC Attributes should be marked as implemented.

lgoltz commented 6 years ago

From http://www.geopackage.org/spec120/#_core and http://www.geopackage.org/spec120/#_options I understand that only the conformance class Core is mandatory. I think all other conformance classes should be removed from https://github.com/opengeospatial/ets-gpkg12/blob/27084850e436846e6811f363ce76db44d549aa8d/src/main/config/teamengine/config.xml as Core is the basic conformance class.

lgoltz commented 6 years ago

Naming of the conformance classes could be improved (adapted to the specification:

dstenger commented 6 years ago

Proposal of https://github.com/opengeospatial/ets-gpkg12/issues/37#issuecomment-363413431 was moved to #41.

dstenger commented 6 years ago

TODOs:

lgoltz commented 6 years ago

TODOs listed in https://github.com/opengeospatial/ets-gpkg12/issues/37#issuecomment-367002858 are implemented in #42:

Check configured basic conformance classes and conformance classes in testng.xml.

Basic CC was not checked as this will be discussed in #41