opengeospatial / ets-ogcapi-edr10

Other
2 stars 5 forks source link

cube endpoints do not specify a coords parameter #130

Open tomkralidis opened 1 month ago

tomkralidis commented 1 month ago

Describe the bug Testing https://demo.pygeoapi.io/master yields an error in the Collections conformance class (cubeCoordsParameterDefinition)

The error from CITE reads:

Required coords parameter for collections with path '/cube' in OpenAPI document is missing expected object to not be null

As per 19-086r6, 8.2.4, an EDR cube query does not specify or require the coords parameter, but bbox instead.

To Reproduce Test https://demo.pygeoapi.io/master against https://cite.opengeospatial.org/teamengine

Expected behavior The test should not check for the existence of a coords parameter for the following query types:

Screenshots Screenshot 2024-07-17 at 09 35 21

Additional context None

dstenger commented 1 month ago

Thanks for reporting.

This issue was already reported https://github.com/opengeospatial/ets-ogcapi-edr10/issues/112 and fixed.

Beta environment contains an installation of that fix (it has not been moved to Production, yet): https://cite.ogc.org/te2/

The test was renamed to cube Bbox Parameter Definition.

I tested your service and get a different error:

cube Bbox Parameter Definition

Expected property 'required' with value 'true' but was 'false'

Can you please check your service regarding this?

Still, we (CITE team) need to check if

must also be adjusted.

Side note: You are referencing the spec of version 1.1. However, this test suite is only suitable for version 1.0.

tomkralidis commented 1 month ago

Thanks @dstenger. I've made some local changes which fix the bbox issue, thanks.

I now see the below issue (6 times), any idea?

Screenshot 2024-07-17 at 17 02 25

tomkralidis commented 1 month ago

Still, we (CITE team) need to check if

  • items
  • locations

must also be adjusted.

Mea culpa. locations does not require a bbox query parameter.

dstenger commented 1 month ago

Thanks for the feedback.

Can you please create a new issue for error detected in https://github.com/opengeospatial/ets-ogcapi-edr10/issues/130#issuecomment-2234287544 as it seems to be a different issue? By viewing your screenshot, I unfortunately do not have an idea what is going wrong here.

Thanks for the clarification in https://github.com/opengeospatial/ets-ogcapi-edr10/issues/130#issuecomment-2234547340. We will still check if any adjustments must be made for "items".

tomkralidis commented 1 month ago

Thanks for the feedback.

Can you please create a new issue for error detected in #130 (comment) as it seems to be a different issue? By viewing your screenshot, I unfortunately do not have an idea what is going wrong here.

Done in #131

Thanks for the clarification in #130 (comment). We will still check if any adjustments must be made for "items".

Thanks!