Add support for OGC API - Features - Part 2: Coordinate Reference Systems by Reference - Githubissues

opengeospatial / ets-ogcapi-features10

Public Repository for the OGC API - Features Compliance Test Suite

Other

16 stars 8 forks source link

Add support for OGC API - Features - Part 2: Coordinate Reference Systems by Reference #127

Closed ghobona closed 3 years ago

ghobona commented 4 years ago

OGC API - Features - Part 2: Coordinate Reference Systems by Reference has passed its TC vote.

Please extend the ETS to include conformance tests from Part 2.

ghobona commented 3 years ago

Agenda

Introductions
Confirm how the deliverable will be completed
- Extension of existing ETS, as a separate a branch
Timetable / schedule
Risks (go through ATS and plan ahead for any potential risks/problems)

dstenger commented 3 years ago

Implementation issues: https://github.com/opengeospatial/ets-ogcapi-features10/issues?q=label%3A%22Part+2%22

Board: https://github.com/opengeospatial/ets-ogcapi-features10/projects/1

dstenger commented 3 years ago

Meeting 2021-05-18:

Limitation of tested features to e.g. 100 (should be configurable via property file).
Possible risks:
- Possible libraries to execute CRS related operations: geotoolkit (geomatics-geotk), apache-sis, proj
- Decision: Go with geotoolkit (geomatics-geotk), if there are any blocking problems, proj might be an alternative.
- Reason: Other test suites use geotoolkit (geomatics-geotk) and as all test suites share the same classpath when deployed to TEAM Engine, problems might occur if we use another library (especially apache-sis).
- Development will be done on following branch: https://github.com/opengeospatial/ets-ogcapi-features10/tree/part2
- When implementation is finished, a pull request will be created to provide the results to main/master branch of test suite.

dstenger commented 3 years ago

Branch for development of tests: https://github.com/opengeospatial/ets-ogcapi-features10/tree/implementPart2-127

dstenger commented 3 years ago

Items to discuss in next meeting:

Can we use Jenkins of OGC CITE team?

dstenger commented 3 years ago

Meeting 2021-05-25:

Can we use Jenkins of OGC CITE team?

Yes, we can use the Jenkins of OGC CITE team.

dstenger commented 3 years ago

Meeting 2021-06-01

lat/lon checks https://github.com/opengeospatial/ets-ogcapi-features10/issues/140 as it is also related to CRS.

dstenger commented 3 years ago

To discuss:

Limit feature related tests to exactly one feature?
Use https://github.com/locationtech/proj4j for transformation of geometries and current JTS version for GeoJSON parser and geometry model?
- Alternatives:
- geotools
- apache-sis (no GeoJSON parser)
- geomatics-geotk (upgrade of geotoolkit is required; no GeoJSON parser)
- deegree
- Proj with JNI (only Java 11)
- Requirements:
- Transformation of coordinates, transformation of geometries, parsing of GeoJSON, (JTS geometry types)

dstenger commented 3 years ago

Decisions made in meeting 2021-06-22:

Limit feature related tests to exactly one feature?

Limit to one feature is fine as this approach was also used in implementation of Part 1.

Use https://github.com/locationtech/proj4j for transformation of geometries and current JTS version for GeoJSON parser and geometry model?

Using proj4j is fine and was already evaluated.

dstenger commented 3 years ago

Pull request was created: https://github.com/opengeospatial/ets-ogcapi-features10/pull/169

Please see https://github.com/opengeospatial/ets-ogcapi-features10/issues?q=label%3A%22Part+2%22+is%3Aclosed for all issues which were solved.