opengeospatial / ets-ogcapi-processes10

Other
3 stars 3 forks source link

Improve message reported about failures of required fields #30

Closed fmigneault closed 8 months ago

fmigneault commented 2 years ago

Is your feature request related to a problem? Please describe.

When one or more required fields are flagged as below:

image

The test should be clearer regarding why the operation failed. In this case, the evaluated instance did have both the id and version fields in its response, but version happened to be defined as null rather than an appropriate version string. The message was therefore misleading in this case.

Describe the solution you'd like The message should make it clear why a given field fails a test. Details about if the field is completely missing, or of invalid type, invalid pattern/format, or other reasons (?) should be added.

dstenger commented 2 years ago

Thank you for reporting. We will do further investigation.

jerstlouis commented 1 year ago

@fmigneault @dstenger @pcdion We run into the same issue with our implementation.

body: Field 'id' is required. (code: 1026)
From: body.<allOf>.<processSummary.yaml>.<allOf>.<required>
body: Field 'version' is required. (code: 1026)
From: body.<allOf>.<processSummary.yaml>.<allOf>.<required>

In our case, all of our processes have version and id and they are both strings, e.g. "1.0.0".

jerstlouis commented 1 year ago

Our latest Processes conformance test is now integrated and this failure can be tested directly from https://maps.gnosis.earth/ogcapi (Gerald's workaround is needed)

bpross-52n commented 1 year ago

@fmigneault @jerstlouis I cannot reproduce this issue. I think this may have been fixed in the meantime. Could you test this again with the current version of the test suite?

dstenger commented 9 months ago

@fmigneault @jerstlouis We will close this PR on the 15th of February if there is no objection.

fmigneault commented 9 months ago

No objection. If the problem is encountered again, I will comment to reopen as necessary.