opengeospatial / ets-sta10

Repository for the Executable Test Suite for OGC Sensor Things API
Other
6 stars 8 forks source link

Invalid encoding type values #16

Closed tebben closed 8 years ago

tebben commented 8 years ago

In different create-update-delete tests unknown encoding types are used, for instance the method putEntities in Capability2Test.java: Location.encodingType: "UPDATED ENCODING" Sensor.encodingType: "http://schema.org/description" FeatureOfInterest.encodingType: "SQUARE"

The documentation describes:

Table 8-6 GeoJSON - application/vnd.geo+json

Table 8-14 PDF - application/pdf SensorML - http://www.opengis.net/doc/IS/SensorML/2.0

Scratchpad is accepting non described encoding types and the sensorup docs (http://www.sensorup.com/docs/) is giving POST examples with unknown encoding types. Can someone explain this? Should we just accept any encoding string or return an error when the encoding type is not supported by the entity type as described in the docs?

bermud commented 8 years ago

@taniakhalafbeigi, can you please explain further and do we need to change anything in the test?

liangsteve commented 8 years ago

@tebben You are right. The test needs to be updated to use only the values of the Value Code list. Good catch.

taniakhalafbeigi commented 8 years ago

The code is updated. Thanks for reporting the problem.