Open mjacoby opened 7 years ago
:+1:
Added tests for creating observations via MQTT
We are going to wait for the API change request before reviewing this pull request. Just a quick comment, MQTT Server should be provided by the user.
Could you please explain at bit more in detail what you mean by "the MQTT Server should be provided by the user"?
Currently we only get the service URL and level of test from user. For MQTT test we need to get MQTT broker address from user too. I am talking about the page that is the user interface when the project is deployed on TEAM Engine.
I understand what you mean. My version committed here reads the broker address from the config file as I don't know anything about the TEAM Engine.
Okay, then I will fix that part of it. But lets wait a little bit for the change request. Just if you are curious, the ctl file under /src/main/scripts/ctl/ needs to be modified. I haven't review the code I just saw this file is not in modified files list, so I am not sure if more modification is needed based on the change in ctl.
How can I build this test? mvn package gives build failure after: '[WARNING] The POM for org.eclipse.paho:org.eclipse.paho.client.mqttv3:jar:1.1.1-SNAPSHOT is missing, no dependency information available'
The paho version can be updated to 1.1.1 (without -SNAPSHOT) I'll update the pull request later this week.
I've updated the pull request to the latest version of the test suite.
thanks, can build and run now :-)
Q: why are you using the 'MQTT_TOPIC_PREFIX' (v1.0/) in the MQTT topic? It's not defined in the spec.
Hmm, if it's not in the topic, how is the server going to know which version the client wants?
ok thanks, so its a proposal to put version number in the MQTT topic, good point.
Yes, but if it does not get accepted, it's just a matter of leaving the prefix empty. It should probably not be set by default, since it's not actually an accepted change.
I'll change the prefix to empty in the pull request.
This pull request implements the tests for receiving updates via MQTT as described in the SensorThings API specification including
Two new properties were added to the properties file
@bertt This might be of interest for you as you were interested in further tests https://github.com/opengeospatial/ets-sta10/issues/6