search

opengeospatial / ets-sta10

Repository for the Executable Test Suite for OGC Sensor Things API
Other
6 stars 8 forks source link

* Added initial tests for the Data Array Extension. #27

Closed hylkevds closed 1 year ago

hylkevds commented 7 years ago

I've added some tests for the Data Array Extension. Of course, depending on responses to https://github.com/opengeospatial/sensorthings/issues/14 some things might have to be tweaked a bit.

hylkevds commented 5 years ago

Considering the speed of development of this test suit I really doubt there will be a problem with the library not being updated fast enough. But you can find it here: https://github.com/FraunhoferIOSB/FROST-Client so feel free to copy it into the project.

taniakhalafbeigi commented 5 years ago

Development speed of this test suite is irrelevant to the problem of this pull request. The OGC test suite should be self-contained with anything related to the standard that it is testing.

hylkevds commented 5 years ago

That's a different argument. Good thing then that in these PRs the library is not used for things that are relevant for the functionality that is being tested. the library is only used for things that are already tested elsewhere in the suite, like creating the related entities needed for the actual tests. The actual testing of the DataArray functionality is done with direct calls. Likewise in the MultiDatasteam tests, the low-level json checks are done directly, only the higher level tests use the library. In the Geospatial Functions test there is nothing low-level to test, since the only thing that is relevant is if the service returns the correct entities.

If you want to pull the library into the suite itself that's not a problem, it's MIT licensed after all, but it's better to do that outside of these pull requests, since it would otherwise cause lots of merge conflicts between these pull requests.