opengeospatial / ets-sta10

Repository for the Executable Test Suite for OGC Sensor Things API
Other
6 stars 8 forks source link

Add detailed error messages #44

Closed taniakhalafbeigi closed 1 year ago

taniakhalafbeigi commented 5 years ago

Currently the error messages does not have the URL to the failed request. If this URL is added to the message, it will be much easier for users to find the cause of a failed test.

dstenger commented 5 years ago

@taniakhalafbeigi Are you working on a solution for this? If not, Keshav can support you with implementation.

taniakhalafbeigi commented 5 years ago

@dstenger I am currently having other issues and PRs in my stack. If Keshav can help with refining the returned error messages, that will be really helpful. Thanks a lot, I really appreciate it.

keshavnangare commented 5 years ago

@taniakhalafbeigi

Can you please review this PR #46? Let me know if you have any changes.

taniakhalafbeigi commented 5 years ago

@keshav-nangare Thanks a lot for you contribution. Your PR looks good. We are looking for detailed error messages for all of our tests. Do you have time to help us with that? Basically we want to do the same thing as you did for PR #46, but for all the tests.

keshavnangare commented 5 years ago

@taniakhalafbeigi

I did the same changes for the tests and pushed into the same branch(PR #46).

Can you please review the changes?

taniakhalafbeigi commented 5 years ago

Thanks a lot @keshav-nangare. Great, thanks a lot. I will take a look later and hopefully we will merge it and have better error messages :tada: