opengeospatial / ets-sta10

Repository for the Executable Test Suite for OGC Sensor Things API
Other
6 stars 8 forks source link

Orderby tests broken #64

Closed hylkevds closed 10 months ago

hylkevds commented 10 months ago

Describe the bug The orderby test creates an invalid URL: https://ogc-demo.k8s.ilt-dmz.iosb.fraunhofer.de/FROST-CERTIFY/v1.0/Things?$orderby=name%20desc. [Request] https://ogc-demo.k8s.ilt-dmz.iosb.fraunhofer.de/FROST-CERTIFY/v1.0/Things?$orderby=name%20asc Yes, that entire thing is the URL it generates.

To Reproduce Steps to reproduce the behavior:

  1. Run the test

Expected behavior No invalid URL generated

Additional context The problem is here

                urlString = ServiceURLBuilder.buildURLString(rootUri, entityType, -1, null, "?$orderby=" + property + "%20desc.  [Request] " + urlString);

The previous value of urlString is appended to the new urlString, including the . [Request] bit.

hylkevds commented 10 months ago

Also:

hylkevds commented 10 months ago

Also explains why all certifications ran out :)

dstenger commented 10 months ago

Thank you for reporting and providing the pull request. Indeed, this seems to be a bug.

hylkevds commented 10 months ago

When do you plan on switching the official test to 1.4? Currently no implementation can pass certification.

dstenger commented 10 months ago

We will release 1.4 on Beta soon (end of November). There it will stay for at least one month before we can move it to Production.

hylkevds commented 10 months ago

Is there anyone actively testing it while it is in Beta? Since obviously no one tested the v1.3 release...

dstenger commented 10 months ago

You are welcome to execute some tests as soon as it is installed on Beta. The release will be announced via the CITE mailing lists. Also, the SWG can be contacted to ask implementers of the standard to test their implementations on Beta.

hylkevds commented 10 months ago

I suspect no one from the STA-SWG in on the CITE mailing list. That would explain why no one tested v1.3 last year. Wouldn't it make more sense to announce the beta release of new version on the mailing list of the relevant SWGs? That way the relevant people are certain to get the notice.

dstenger commented 10 months ago

Thank you for the feedback. We just discussed your ideas in the CITE team. To avoid heavy traffic on the SWG mailing lists we will send out an email to TC Announce to encourage users to sign up for the CITE forum mailing list. Cc @ghobona

hylkevds commented 10 months ago

I will not be subscribing to a mailing list of with 99% of the messages don't interest me. Since that will just result in me probably overlooking that one message every 2 years that does interest me. If you don't want to send these announcements to the SWG mailing list you should create a mailing list for each test suite.

danistrigaro commented 3 months ago

We will release 1.4 on Beta soon (end of November). There it will stay for at least one month before we can move it to Production.

Dear, it would be nice to have the new version in production, since we spent a lot of time to find out this issue. By the way thank you for reporting and commenting and linking the beta version!

dstenger commented 3 months ago

We will update the Production environment this summer. Please monitor the CITE forum mailing list to receive the announcement.