opengeospatial / ets-wfs11

Executable Test Suite for WFS 1.1
Other
1 stars 5 forks source link

Add conformance class configuration into the wfs11 test #68

Closed keshavnangare closed 6 years ago

keshavnangare commented 7 years ago

The test needs to be updated to better provide information about the grouping of the conformance class and determination about which ones are the basic conformance classes needed for certification.

Changes that are required are described here:

https://github.com/opengeospatial/cite/wiki/Encoding-Conformance-Classes

lgoltz commented 7 years ago

WFS 1.1.0 specifies the following classes of web feature services (p. 3):

The ETS groups the test in the following conformance classes (from the main entry point):

With the exception of WFS-Locking these are identical. The WFS 1.1.0 specifies the LockFeature operations as optional part of the Transaction WFS. I think the grouping in the ETS is fine so far.

As already described for the WMS 1.3 ETS we have a problem with the hierarchy depth: the new HTML report allows only a depth of 2, while the ETS has more hierarchy levels.

lgoltz commented 7 years ago

Added conformance class configuration: https://github.com/opengeospatial/ets-wfs11/commit/d4938cb54d7eb920ebd9998371ac78ed92eb5ec8

Cause of https://github.com/opengeospatial/teamengine/issues/263 the output contains only the link to old test report.

lgoltz commented 7 years ago

With the fix https://github.com/opengeospatial/teamengine/pull/264 the new HTML report is empty.

In the CTL log file the conformance class is marked. In the earl-results.pdf the section with the requirements is empty:

  <cite:TestRun>
    <cite:inputs>
       ...
    </cite:inputs>
    <cite:testsNotTested rdf:datatype="http://www.w3.org/2001/XMLSchema#int"
    >0</cite:testsNotTested>
    <cite:requirements>
      <rdf:Seq/>
    </cite:requirements>  

I assume the CTL scripts needs a refactoring regarding the test structure.

keshavnangare commented 7 years ago

According to documentation all conformance classes should be in the main.ctl file i.e. starting point of the test.

https://github.com/opengeospatial/cite/wiki/Encoding-Conformance-Classes

If we added this conformance classes in other places(files) then the CtlEarlReporter classes is not able to identify the conformance classes. So its mandatory to add in main.ctl file.

lgoltz commented 7 years ago

@keshav-nangare Is the starting point decisive or the hierarchy level? A test suite could be completely scripted in one CTL file but with arbitrary hierarchy levels.

keshavnangare commented 7 years ago

To maintain the hierarchy level of conformance classes and its sub-tests. The CtlEarlReporter will get the first level as conformance classes and then it will process all the sub-tests.

lgoltz commented 6 years ago

Test was restructured that the configuration of the conformances classes is on the second level. Previously the main test wfs:wfs-main called the test wfs:readiness-tests which called the test configured as conformance class (configured in https://github.com/opengeospatial/ets-wfs11/issues/68#issuecomment-342425476). Now the test wfs:wfs-main calls the test wfs:readiness-tests which was configured as basic conformance class. Furthermore the call of the tests already configured as conformance class are called by the test wfs:wfs-main now, too.

Commit: https://github.com/opengeospatial/ets-wfs11/commit/a42dc5bd9c4482d9decba289fb5d8e711268693c