opengeospatial / ets-wfs20

Executable Test Suite for WFS 2.0
Other
8 stars 11 forks source link

NullPointerException when running v1.38 of the WFS compliance test #230

Closed robinhoutmeyers closed 1 year ago

robinhoutmeyers commented 2 years ago

Hi, we have an automated test that runs the latest version of the WFS 2.0 compliance test against our WFS server implementation; this test started failing since v1.38, with the following exception:

CITE > [TestNG] Reporter com.occamlab.te.spi.executors.testng.EarlReporter@62fdb4a6 failed CITE > java.lang.NullPointerException CITE > at com.occamlab.te.spi.executors.testng.EarlReporter.isBasicConformanceClass(EarlReporter.java:451) CITE > at com.occamlab.te.spi.executors.testng.EarlReporter.addTestRequirements(EarlReporter.java:240) CITE > at com.occamlab.te.spi.executors.testng.EarlReporter.generateReport(EarlReporter.java:103) CITE > at org.testng.TestNG.generateReports(TestNG.java:1135) CITE > at org.testng.TestNG.run(TestNG.java:1081) CITE > at com.occamlab.te.spi.executors.testng.TestNGExecutor.execute(TestNGExecutor.java:137) CITE > at org.opengis.cite.iso19142.TestNGController.doTestRun(TestNGController.java:142) CITE > at org.opengis.cite.iso19142.TestNGController.main(TestNGController.java:82)

Could this be a regression?

dstenger commented 2 years ago

Thank you for reporting. How do you execute the tests? REST Interface, Web Browser Interface, CLI or via Java directly? Is it possible to provide a test service to reproduce the issue?

robinhoutmeyers commented 2 years ago

Hi, I am running it through CLI; however, I found out that the problem is the same as https://github.com/opengeospatial/ets-wfs20/issues/205; we've now reverted to v1.37, which seems to work well.

dstenger commented 2 years ago

Thanks for reporting back. However, the CLI should also work with v1.38. We will take a look into this. Can you please provide the command you used to execute the CLI? What content was provided by the used test-run-props.xml?

robinhoutmeyers commented 2 years ago

This is the content of test-run-props.xml:

<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE properties SYSTEM "http://java.sun.com/dtd/properties.dtd">

Test run arguments (ets-wfs20) GET_REQUEST_URL_REGEX

This is the command that we use:

java -Duser.home=C:\Users\abc\wfs_cite_tests_home_dir -jar C:\Users\abc\wfs_cite_tests_home_dir\wfs-20-aio.jar -o file:///C:/xyz/report/junit/ tempFile.xml

bpross-52n commented 1 year ago

@robinhoutmeyers The WFS 2.0 test suite in version 1.38 is using a new version of teamengine. The EarlReporter is now requiring a config.xml file, see also here . You could specify another environment variable named TE_BASE specifying the directory, that contains the config.xml.

dstenger commented 1 year ago

@robinhoutmeyers We enhanced the documentation in https://github.com/opengeospatial/ets-wfs20/pull/245. Can you please check if that solves your problem?

dstenger commented 1 year ago

We decided to fix the problem in TEAM Engine so that it is not mandatory to reference an external config.xml anymore: https://github.com/opengeospatial/teamengine/issues/561

dstenger commented 1 year ago

We decided to close the PR of this repo: https://github.com/opengeospatial/ets-wfs20/pull/245. However, if you are interested, it describes a workaround for the problem (this comment must also be considered https://github.com/opengeospatial/ets-wfs20/pull/245#issuecomment-1316744224).