search

opengeospatial / ets-wfs20

Executable Test Suite for WFS 2.0
Other
8 stars 11 forks source link

Config.xml example file is missing the config tag #261

Open ihsanyapicioglu opened 9 months ago

ihsanyapicioglu commented 9 months ago

Dear all,

When the project is being updated to 1.40 or to the master branch, it uses the teamengine-core version 5.6.1. In this dependency, a method named getOrganizations has been implemented to Config.java class. This method is looking for a "config" tag inside of the given config.xml file. However in the config.xml file under "src/main/config/teamengine" directory of ets-wfs20 project's master branch and 1.40 tag, there is no config tag. Most probably this example config file has not been updated yet after updating the dependency of the teamengine.

dstenger commented 9 months ago

Thank you for reporting.

You are probably referring to this pull request? https://github.com/opengeospatial/teamengine/pull/562 This pull request reduces the preconditions for a config.xml file. So, it does not add any new functionality.

The line you are referencing

            Element configElem = (Element) (doc.getElementsByTagName("config")
                    .item(0));

was just refactored to this new method and already existed before. After parsing the config.xml the first child is config which is retrieved by that line.

So, the config.xml must not be updated as this pull request does not change the requirements for that file.

dstenger commented 9 months ago

@ihsanyapicioglu Can you please confirm if my answer solves your problem? If not, can you please provide more details?