opengeospatial / ets-wms-client13

Repository for the Exectutable Test Suite for WMS Client 1.3.X
Other
1 stars 3 forks source link

Update CTL with better information about conformance classes #23

Closed keshavnangare closed 5 years ago

keshavnangare commented 7 years ago

The test needs to be updated to better provide information about the grouping of the conformance class and determination about which ones are the basic conformance classes needed for certification.

Changes that are required are described here:

https://github.com/opengeospatial/cite/wiki/Encoding-Conformance-Classes

lgoltz commented 6 years ago

I think all tests except GetFeatureInfo have to be declared as cc and basic.

lgoltz commented 6 years ago

As far as I see with the current structure of the tests the conformance classes cannot be configured. @keshav-nangare Do you have an idea?

keshavnangare commented 6 years ago

Teamengine failed to generate new HTML report after CC configuration due to the empty test-inputs, so creating a new issue in teamengine section.

dstenger commented 6 years ago

Configuration of CCs must still be done.

lgoltz commented 6 years ago

Teamengine failed to generate new HTML report after CC configuration due to the empty test-inputs, so creating a new issue in teamengine section.

After merging https://github.com/opengeospatial/teamengine/pull/349 the new HTML report is available.

lgoltz commented 6 years ago

Tested locally with Docker environment (with current teamengine SNAPSHOT and ETS branch feature-issue#23) and QGIS 3.4 the new HTML report does not match the old report. The old report is fine (the selected layers are marked as passed):

ets-wms-client13-23_oldreport

But in the new HTML report all tests are passed:

ets-wms-client13-23_htmlreport

dstenger commented 5 years ago

Workaround: Disable new HTML report and introduce same behaviour occurring when basic conformance classes are not configured.

keshavnangare commented 5 years ago

@dstenger

The PR https://github.com/opengeospatial/ets-wms-client13/pull/39 contains the basic CC configurationis and it's not merged into master. If we not merging this PR then it will work as we are expecting in previous comment. We can keep this PR in waiting or close for now.