search

opengeospatial / ets-wms-client13

Repository for the Exectutable Test Suite for WMS Client 1.3.X
Other
1 stars 3 forks source link

When stopping the test without any request the result is incorrect and missing information #7

Closed bermud closed 9 years ago

bermud commented 9 years ago

Tested TE https://github.com/opengeospatial/teamengine/commit/13b8e3b2b34034cc81aa31848111e31b91bee1bd

WMS 1.3 client test v 0.6

error

bermud commented 9 years ago

It seems is an error when stopping the test from the upper right stop button. The stop button at the bottom of the test works fine. Please fix any issues on the upper right test button and change the behavior of the bottom stop button to match the behavior of the upper right button (i.e. make the same call).

upendra-sachan commented 9 years ago

Hi Luis,

Yes, It is a issue for all test when stopping the test from the upper right stop. The stop button at bottom of the test works fine. Because when we click upper right stop it call this method:

if (operation.equals("Stop")) { response.setContentType("text/xml"); TECore core = (TECore) session.getAttribute("testsession"); if (core != null) { core.stopThread(); session.removeAttribute("testsession"); out.println(""); } else { out.println("Could not retrieve core object"); } }

Which actually sleeps the thread infinitely. We cant get the test status recordings at this place, since tests run in respective projects.

We can trigger the method for bottom stop test button from upper stop test button. So for this we can apply this solution:

Thanks.

Upendra Sachan Mindstix Software Labs http://www.mindstix.com

Email: upendra.sachan@mindstix.com blah@mindstix.com Phone: +91 8446253174 Skype: upendra.sachan1

On Wed, Mar 4, 2015 at 10:41 PM, Luis Bermudez notifications@github.com wrote:

It seems is an error when stopping the test from the upper right stop button. The stop button at the bottom of the test works fine. Please fix any issues on the upper right test button and change the behavior of the bottom stop button to match the behavior of the upper right button (i.e. make the same call).

— Reply to this email directly or view it on GitHub https://github.com/opengeospatial/ets-wms-client13/issues/7#issuecomment-77200433 .

bermud commented 9 years ago

Why don't you add another attribute like testid to the session

If the testid !=null, call the new stop process If not, behave as usual

bermud commented 9 years ago

Fixed here: https://github.com/opengeospatial/teamengine/commit/9539472571fceb938fad6c094e32c50dabaed000