search

opengeospatial / ets-wms13-nsg

0 stars 0 forks source link

Add conformance class configuration into the ets-wms13-nsg test #3

Closed keshavnangare closed 6 years ago

keshavnangare commented 6 years ago

The test needs to be updated to better provide information about the grouping of the conformance class and determination about which ones are the basic conformance classes needed for certification.

Changes that are required are described here:

https://github.com/opengeospatial/cite/wiki/Encoding-Conformance-Classes

lgoltz commented 6 years ago

Conformance classes was configured in #1:

Tested locally with TEAM Engine 5.2. Currently the following results are shown in the new HTML report:

As the conformance class "WMS Basic" is currently empty it is skipped. It must be checked why "Passed core (Can be certified)" is unclear.

keshavnangare commented 6 years ago

@lgoltz

Can you please provide the session log and service URL?

lgoltz commented 6 years ago

Tested on beta with http://cite.deegree.org/deegree-webservices-3.4-RC3/services/wms130?request=GetCapabilities&service=WMS

I'm currently not able to download the session log.

keshavnangare commented 6 years ago

@lgoltz

This issue is occurring due to duplicate jar of the same test in /lib/ directory. The EearReporter class is using the test-suite name to read the list basic conformance classes. If the duplicate jar of execution test is present then it is taking the older version so the condition is getting false because the version is not matching with the current one.

If we removed that duplicate jar then it is working as expected.

I have observed one thing while executing the ets-wms13-nsg test, Java runtime using jar with the name dgiwg-wms13-0.4-SNAPSHOT but the original name of the jar is ets-wms13-nsg-0.2-SNAPSHOT (according to the project) so the name is not matching. i.e. the reason of unclear core conformance classes.

Solution: If we removed the duplicate jar then it will execute as expected. Then no changes are required in test as well as teamengine.

lgoltz commented 6 years ago

The jars dgiwg-wms13-0.4-SNAPSHOT and ets-wms13-nsg-0.2-SNAPSHOT are no duplicates. NSG is a profile encapsulating DGIWG (encapsulation WMS), so both jars are required.

But this was the decisive information, the name of the suite in the testng.xml was incorrect. Fixed on master: https://github.com/opengeospatial/ets-wms13-nsg/commit/a196ca507018ea080a7db871826e95e58bc57053

dstenger commented 6 years ago

Functional test

Tested with teamengine-docker and basic conformance classes are displayed in new HTML report.