opengeospatial / ets-wms13

Repository for the Exectutable Test Suite for WMS 1.3.0
Apache License 2.0
2 stars 4 forks source link

Worlfiles for testing WMS 1.3.0 raster conformance link does not exist #104

Closed bangph closed 1 year ago

bangph commented 1 year ago

This is the correct link to download the worldfiles for testing WMS 1.3.0 supporting raster only:
https://github.com/opengeospatial/ets-wms13/raw/master/src/site/resources/png-worldfiles-wms-1.3.0.zip

But in https://github.com/opengeospatial/ets-wms13/blob/master/src/site/markdown/index.md it points to non-existing link at

If your WMS server only supports raster files as input, then download this alternative test dataset of PNG worldfiles.

I also found that this link https://github.com/opengeospatial/ets-wms13/blob/master/src/site/markdown/data-wms-1.3.0.zip doesn't exist on the https://github.com/opengeospatial/ets-wms13/blob/master/src/site/markdown/index.md at:

If your WMS server supports vector files as input, then download this test dataset of Shapefiles.

There are also no IMAGES displayed on https://github.com/opengeospatial/ets-wms13/blob/master/src/site/markdown/index.md (these image links are also broken)

@dstenger

dstenger commented 1 year ago

Thank you for reporting.

These sites are optimized for usage via

The links work there and images are displayed. Does this answer your question?

bangph commented 1 year ago

@dstenger although your listed sites look good, but I still think you should fix them in the github https://github.com/opengeospatial/ets-wms13/blob/master/src/site/markdown/index.md as well (or you can remove this page instead).

dstenger commented 1 year ago

The referenced file is actually the source code of the pages I referenced.

@ghobona I am not too sure about your commit replacing the relative URL with an absolute URL because now you are always redirected to te2. This means that a custom installation (which is e.g. in an internal network) will always point to te2, same for production. If e.g. on Production there is an older version of the test suite, it will still point to the newer test data of te2. In addition, I don't think it is a good idea to have a hard coded link to te2. I prefer the solution with the relative URL as it will also work in closed networks (e.g. without internet) and the test data on Beta might not always match with the version of the test suite installed.

ghobona commented 1 year ago

@dstenger I accept that the approach in the commit has those limitations and I have closed the PR without merging.

@bangph The optimal solution is to leave the page as it currently is. The page is not meant to be read on the GitHub repo, because it is a source file in markdown, meant for generating HTML pages that are rendered for presentation.