opengeospatial / ets-wms13

Repository for the Exectutable Test Suite for WMS 1.3.0
Apache License 2.0
2 stars 4 forks source link

Wrong test description for test WMS basic:layer-order #105

Closed bangph closed 1 year ago

bangph commented 1 year ago

In this link https://cite.ogc.org/te2/listings/te_base_scripts_wms13_1.3.0_ctl_main.html#basic:layer-order it says:

The user will be asked to manually verify that for request #1, Goose Island, Blue Lake, and Ashton are above State Forest. For request #2, State Forest is above Ashton, and Blue Lake and Goose Island are not visible.

But actually there are no Goose Island and Ashton layers used in the CTL code:

<xsl:attribute name="src">
                              <xsl:value-of select="functions:correct-url-prefix(wms:Capability/wms:Request/wms:GetMap/wms:DCPType/wms:HTTP/wms:Get/wms:OnlineResource/@xlink:href)"/>
                              <xsl:text>VERSION=</xsl:text>
                              <xsl:value-of select="functions:version()"/>
                              <xsl:text>&amp;REQUEST=GetMap</xsl:text>
                              <xsl:text>&amp;LAYERS=</xsl:text>
                              <xsl:value-of select="functions:encode(string(wms:Capability//wms:Layer[wms:Name = 'Forests' or wms:Name = 'cite:Forests']/wms:Name))"/>
                              <xsl:text>,</xsl:text>
                              <xsl:value-of select="functions:encode(string(wms:Capability//wms:Layer[wms:Name = 'Lakes' or wms:Name = 'cite:Lakes']/wms:Name))"/>
                              <xsl:text>,</xsl:text>
                              <xsl:value-of select="functions:encode(string(wms:Capability//wms:Layer[wms:Name = 'NamedPlaces' or wms:Name = 'cite:NamedPlaces']/wms:Name))"/>
                              <xsl:text>&amp;STYLES=</xsl:text>
                              <xsl:text>&amp;CRS=CRS:84</xsl:text>
                              <xsl:text>&amp;BBOX=-0.0042,-0.0024,0.0042,0.0024</xsl:text>
                              <xsl:text>&amp;WIDTH=168</xsl:text>
                              <xsl:text>&amp;HEIGHT=96</xsl:text>
                              <xsl:text>&amp;FORMAT=</xsl:text>
                              <xsl:value-of select="functions:encode(wms:Capability/wms:Request/wms:GetMap/wms:Format[starts-with(., 'image/png') or starts-with(., 'image/gif') or starts-with(., 'image/jpeg')][1])"/>
                           </xsl:attribute>

and for request #2

                           <xsl:attribute name="src">
                              <xsl:value-of select="functions:correct-url-prefix(wms:Capability/wms:Request/wms:GetMap/wms:DCPType/wms:HTTP/wms:Get/wms:OnlineResource/@xlink:href)"/>
                              <xsl:text>VERSION=</xsl:text>
                              <xsl:value-of select="functions:version()"/>
                              <xsl:text>&amp;REQUEST=GetMap</xsl:text>
                              <xsl:text>&amp;LAYERS=</xsl:text>
                              <xsl:value-of select="functions:encode(string(wms:Capability//wms:Layer[wms:Name = 'NamedPlaces' or wms:Name = 'cite:NamedPlaces']/wms:Name))"/>
                              <xsl:text>,</xsl:text>
                              <xsl:value-of select="functions:encode(string(wms:Capability//wms:Layer[wms:Name = 'Lakes' or wms:Name = 'cite:Lakes']/wms:Name))"/>
                              <xsl:text>,</xsl:text>
                              <xsl:value-of select="functions:encode(string(wms:Capability//wms:Layer[wms:Name = 'Forests' or wms:Name = 'cite:Forests']/wms:Name))"/>
                              <xsl:text>&amp;STYLES=</xsl:text>
                              <xsl:text>&amp;CRS=CRS:84</xsl:text>
                              <xsl:text>&amp;BBOX=-0.0042,-0.0024,0.0042,0.0024</xsl:text>
                              <xsl:text>&amp;WIDTH=168</xsl:text>
                              <xsl:text>&amp;HEIGHT=96</xsl:text>
                              <xsl:text>&amp;FORMAT=</xsl:text>
                              <xsl:value-of select="functions:encode(wms:Capability/wms:Request/wms:GetMap/wms:Format[starts-with(., 'image/png') or starts-with(., 'image/gif') or starts-with(., 'image/jpeg')][1])"/>
                           </xsl:attribute>

@dstenger

dstenger commented 1 year ago

I checked the test data: Ashton and Goose Island are part of layer NamedPlaces. Thus, the comment seems to be correct.

bangph commented 1 year ago

@dstenger it is very confusing because what I got from Worldfiles for WMS raster conformance is:

Autos.png
BasicPolygons.png
Bridges.png
BuildingCenters.png
Buildings.png
DividedRoutes.png
Forests.png
Lakes.png
lakesWithElevation.png
MapNeatline.png
NamedPlaces.png
Ponds.png
RoadSegments.png
Streams.png

I don't know where Ashton and Goose Island come from.

dstenger commented 1 year ago

As I already said, Ashton and Goose Island come from NamedPlaces.png. Can you please describe more in detail where you are confused during the setup? Maybe, the sample map on https://cite.ogc.org/te2/about/wms13/1.3.0/site/ (Figure 1) helps you to understand this better?

bangph commented 1 year ago

@dstenger The confusion came from I thought Ashton and Goose Island should exist as two separated files and I didn't see them from the provided worldfiles for raster conformance.

But, with the image you pointed out, it makes sense now.