search

opengeospatial / ets-wms13

Repository for the Exectutable Test Suite for WMS 1.3.0
Apache License 2.0
2 stars 4 forks source link

Test time:time-current-interval finishes with status "Continue" when using TEAM Engine 5.7 #113

Open dstenger opened 2 months ago

dstenger commented 2 months ago

Describe the bug When the test suite is executed with TEAM Engine 5.7, one test finishes with status "Continue" which is considered as a fail:

The CTL/XPath is probably erroneous leading to that behavior and must be fixed.

To Reproduce Steps to reproduce the behavior:

  1. Start test suite with TEAM Engine 5.7.
  2. Execute tests with reference implementation and select optional tests for TIME.
  3. View test results via "detailed old test report".

Expected behavior No test shall finish with status "Continue"

Screenshots Bildschirmfoto vom 2024-06-20 11-50-22

Additional context Most likely related to this issue: https://github.com/opengeospatial/ets-wcs10/issues/59

bpross-52n commented 1 month ago

Imho the test failed also with older versions of TEAM Engine, but it was not displayed correctly. This is the log output from a run with TEAM Engine 5.6.1:

******************************************************************************************************************************

            Testing time:time-current-interval type Mandatory in Retest Mode with defaultResult Pass (s0001/d8038e18227_1/d8038e16364_1/d8038e16392_1/d8038e16577_1)...

               Context: WMS_Capabilities element

               Assertion: If the time dimension supports the current keyword and advertises an interval ending with current, a request for that interval returns a map.

******************************************************************************************************************************

               Testing time:time-default type Mandatory in Retest Mode with defaultResult Pass (s0001/d8038e18227_1/d8038e16364_1/d8038e16392_1/d8038e16579_1)...

                  Context: WMS_Capabilities element

                  Assertion: If the dimension decalaration includes a default value, a request without a TIME parameter returns a map and sets the "default value used" warning header.

               Test time:time-default Passed

******************************************************************************************************************************

The statement Test time:time-current-interval Passed is missing from the logs. I believe there is an issue with a XPath expression in that test (see here , the expression and contains(., '/current')) that was not handled correcty before the TEAM Engine 5.7 release (see here). I have created a pull request modifying the XPath expression and now the time:time-current-interval test passes.