opengeospatial / ets-wms13

Repository for the Exectutable Test Suite for WMS 1.3.0
Apache License 2.0
2 stars 4 forks source link

Extracting local names and prefixes #39

Closed keshavnangare closed 7 years ago

keshavnangare commented 7 years ago

35

  1. Need to add the conformance class configuration attributes in the conformance class test to represent the conformance classes in the EARL report.

For example: <ctl:test name="getcapabilities:main" isConformanceClass="true" isBasic="false">

"isBasic": Represent the basic conformance class. Its value is 'true' if that conformance class is basic otherwise is 'false'.

  1. Update the testName with well-formatted name:
e.g. : <ctl:call-test name="getmap:main">
  <ctl:with-param name="exhaustive" select="$exhaustive"/>
  </ctl:call-test>

  <ctl:call-test name="getfeatureinfo:main"/>

  <ctl:call-test name="dims:main"/>

If you observed the above code snippet the name of the tests are the same and the prefixes are different. After execution of the test, only the name (prefix: name) appears in the log. In the above case, all the tests have the same name prefix i.e. "main". We can't recognize the test which belongs to by just using the name.

So we need good test names which we can use to represent the better HTML report.

  1. We need all the conformance classes in the root test.

Following is the ctl sampleTest which represents the conformance class:

sampleTest.zip

bermud commented 7 years ago

The CTL tests refer to tests and sometimes put the prefix before and sometimes after. This might be a related problem.

             <ctl:call-test name="interactive:main">
               <ctl:with-param name="basic" select="$basic"/>
            </ctl:call-test>

            <ctl:call-test name="main:options-requirements">
               <ctl:with-param name="basic" select="$basic"/>
               <ctl:with-param name="queryable" select="$queryable"/>
               <ctl:with-param name="raster_elevation" select="$raster_elevation"/>
               <ctl:with-param name="vector_elevation" select="$vector_elevation"/>
               <ctl:with-param name="time" select="$time"/>
            </ctl:call-test>

            <ctl:call-test name="basic_elements:main"/>

            <ctl:call-test name="getcapabilities:main">
               <ctl:with-param name="high-updatesequence" select="$high-updatesequence"/>
               <ctl:with-param name="low-updatesequence" select="$low-updatesequence"/>
            </ctl:call-test>
bermud commented 7 years ago

'main' can be a prefix and in some cases it can be a local test as well. If we have text1:text2, text1 is always the prefix and text2 is always the local name.

dstenger commented 7 years ago

Nest step: Refactoring of prefixes and names.

dstenger commented 7 years ago

Refactoring was executed and is provided via pull request #47.

dstenger commented 7 years ago

Refactoring was tested successfully, merged into master branch and will be part of the next release.